Fix commit_sig encoding #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #33 +/- ##
========================================
+ Coverage 38.7% 40.1% +1.4%
========================================
Files 17 17
Lines 1899 1927 +28
========================================
+ Hits 734 772 +38
+ Misses 1165 1155 -10
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
crisdut
force-pushed
the
fix/commit-sig-encondig
branch
from
f36cb72
to
72d2c8d
Compare
dr-orlovsky
requested changes
Apr 3, 2023
lnp2p/src/bolt/bolt2.rs
Outdated
Comment on lines
747
to
750
|
|
||
| let buf: Vec<u8> = vec![]; | ||
| e.write_all(&buf)?; | ||
| Ok(buf.len()) |
There was a problem hiding this comment.
Can you pls explain what this code tries to achieve?
There was a problem hiding this comment.
Return the number of bytes.
There was a problem hiding this comment.
It will always return zero. It does nothing
crisdut
force-pushed
the
fix/commit-sig-encondig
branch
from
72d2c8d
to
5f09112
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @dr-orlovsky,
I tried to solve this issue related to this comment.