Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update MSRV to 1.76 (due to ascii-armor) #184

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

zoedberg
Copy link
Member

No description provided.

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.2%. Comparing base (4ab7d0d) to head (0d2f818).
Report is 37 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #184     +/-   ##
========================================
- Coverage    67.3%   63.2%   -4.1%     
========================================
  Files          20      18      -2     
  Lines        1982    1715    -267     
========================================
- Hits         1334    1084    -250     
+ Misses        648     631     -17     
Flag Coverage Δ
rust 63.2% <ø> (-4.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zoedberg
Copy link
Member Author

I'm trying to understand why the testing (macos-13) job fails. @dr-orlovsky have you ever encountered such issue?

@zoedberg
Copy link
Member Author

It seems it was just a temporary issue. I don't understand why there's an expected check still called toolchains (1.75.0) though, @dr-orlovsky do you have any idea? Apart from that this PR can be merged

@dr-orlovsky
Copy link
Member

I'm trying to understand why the testing (macos-13) job fails. @dr-orlovsky have you ever encountered such issue?

Yes, all the time. It seems github has a low availability of apple silicon machines and fequently CI hangs on macos-13 (as well as windows sometimes).

an expected check still called toolchains (1.75.0)

It should be changed in the branch rules in settings. Doing that.

Copy link
Member

@dr-orlovsky dr-orlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 0d2f818

@dr-orlovsky dr-orlovsky added the ci Contininous integration-relased issue label Sep 17, 2024
@dr-orlovsky dr-orlovsky added this to the v0.11.0 milestone Sep 17, 2024
@dr-orlovsky dr-orlovsky merged commit 1e8fe81 into LNP-BP:master Sep 17, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Contininous integration-relased issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants