Make MerkleBuoy generic utility #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dr-orlovsky
added
enhancement
Merged
zoedberg
approved these changes
Oct 9, 2023
There was a problem hiding this comment.
I've patched commit_verify on rgb-lib and ran tests, they all pass so IMO this can be merged.
P.S. Also here I see some lint warnings, as already said in BP-WG/bp-core#56 (comment) I think we should solve them and fix the CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MerkleBuoyis a helper that ensures that unbalanced Merkle trees iterated over their leaves run iteration in full.Previously
MerkleBuoywas used only internally for merging two MPC Merkle blocks. While implementing taproot support in newbp-stdandpsbtcrates I stumbled upon the need for a similar structure with different max depth. So instead of creating a new one, I export this structure putting it intomerklemodule (where it belongs to, since it is not just MPC-specific anymore) and making it generic over the depth. None of the existing business logic or validation code must be affected.