Ensure that fee minimum estimate is returned when no estimates #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrfelton
added
the
type:bug
pmilic021
reviewed
Jul 15, 2024
Comment on lines
+41
to
+45
| const feeEstimates = { | ||
| "1": 1, | ||
| "2": 1, | ||
| "3": 1, | ||
| }; |
There was a problem hiding this comment.
Should be empty, correct? nvm, just noticed it is all below the min
There was a problem hiding this comment.
The fee minimum us set at 2. So this is simulating the case where three estimates are sourced but all of them are below the min fee limit.
pmilic021
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request primarily introduces a new feature to the
DataProviderManagerclass and adds corresponding tests. The main change is the addition of a condition to handle cases when there are no fee estimates above the fee minimum. In such cases, a single estimate at the fee minimum is added. Two new tests have been added to validate this functionality.src/lib/DataProviderManager.ts: Added a condition to check if the length offeeEstimatesis zero. If it is, a single estimate at the fee minimum is added tofeeEstimates.Testing:
test/DataProviderManager-minfee.test.ts: Added two new tests. The first test checks that estimates below the fee minimum are excluded. The second test ensures that if no valid estimates are available, a single estimate at the fee minimum is returned.