Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only Print Duplicates in Error Message #226

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Only Print Duplicates in Error Message #226

wants to merge 2 commits into from

Conversation

michaelmckinsey1
Copy link
Collaborator

@michaelmckinsey1 michaelmckinsey1 commented Nov 12, 2024 •
edited
Loading

From the error message in develop, it is hard to tell which index is the duplicate when there are many profiles. In this example the duplicate is 3723623787.

develop
Screenshot from 2024-11-11 20-53-17

This PR
Screenshot from 2024-11-11 20-54-44

@michaelmckinsey1 michaelmckinsey1 self-assigned this Nov 12, 2024
@michaelmckinsey1 michaelmckinsey1 added area-utils Issues and PRs related to Thicket's internal utilities and helpers priority-normal Normal priority issues and PRs status-ready-for-review This PR is ready to be reviewed by assigned reviewers type-internal-cleanup PRs or Issues related to the structure of the codebase, directories, and refactors labels Nov 12, 2024
@michaelmckinsey1 michaelmckinsey1 marked this pull request as ready for review November 12, 2024 23:39
@slabasan
Copy link
Collaborator

@michaelmckinsey1 Are you able to amend this PR to check for duplicates earlier? Can we update the error message to report collisions to us?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slabasan slabasan Awaiting requested review from slabasan

At least 1 approving review is required to merge this pull request.

Assignees

@michaelmckinsey1 michaelmckinsey1

Labels
area-utils Issues and PRs related to Thicket's internal utilities and helpers priority-normal Normal priority issues and PRs status-ready-for-review This PR is ready to be reviewed by assigned reviewers type-internal-cleanup PRs or Issues related to the structure of the codebase, directories, and refactors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelmckinsey1 @slabasan