ARKODE Order Checking Improvements #640
Draft
+697
−4,168
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces a few thousand lines of hard-coded order conditions with systematic, arbitrary order checking.
In draft status because I'd like to see about changing the return values of
ARKodeButcherTable_CheckOrder
andARKodeButcherTable_CheckARKOrder
. Currently, they handle return values of-1
and-2
inconsistently. I'd like to propose returningARK_*
errors, e.g.,ARK_SUCCESS
,ARK_MEM_NULL
,ARK_MEM_FAIL
, etcARK_ORDER_OVERESTIMATE
error code if supplied order is greater than computedARK_WARNING
or newARK_WARNING_ORDER_UNDERESTIMATE
if supplied order is less than computedI suppose that would be considered a breaking change, though.