Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARKODE Order Checking Improvements #640

Draft
wants to merge 17 commits into
base: develop
Choose a base branch
from

Conversation

Steven-Roberts
Copy link
Collaborator

Replaces a few thousand lines of hard-coded order conditions with systematic, arbitrary order checking.

In draft status because I'd like to see about changing the return values of ARKodeButcherTable_CheckOrder and ARKodeButcherTable_CheckARKOrder. Currently, they handle return values of -1 and -2 inconsistently. I'd like to propose returning ARK_* errors, e.g.,

  • ARK_SUCCESS, ARK_MEM_NULL, ARK_MEM_FAIL, etc
  • A new ARK_ORDER_OVERESTIMATE error code if supplied order is greater than computed
  • ARK_WARNING or new ARK_WARNING_ORDER_UNDERESTIMATE if supplied order is less than computed

I suppose that would be considered a breaking change, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant