-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release: 7.2.0 sync main with develop #621
Merged
+130,170
−22,117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add CMake formatter
Ignore recent revisions for Python and CMake formatting in git blame
Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 6.0.2 to 6.3.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/docker/build-push-action/releases">docker/build-push-action's releases</a>.</em></p> <blockquote> <h2>v6.3.0</h2> <ul> <li><code>DOCKER_BUILD_RECORD_UPLOAD</code> environment variable to enable/disable build record upload by <a href="https://github.com/crazy-max"><code>@crazy-max</code></a> in <a href="https://redirect.github.com/docker/build-push-action/pull/1172">docker/build-push-action#1172</a></li> <li><code>DOCKER_BUILD_NO_SUMMARY</code> has been deprecated. Set <code>DOCKER_BUILD_SUMMARY</code> to <code>false</code> instead by <a href="https://github.com/crazy-max"><code>@crazy-max</code></a> in <a href="https://redirect.github.com/docker/build-push-action/pull/1170">docker/build-push-action#1170</a> <a href="https://redirect.github.com/docker/build-push-action/pull/1173">docker/build-push-action#1173</a></li> <li>Bump <code>@docker/actions-toolkit</code> from 0.28.0 to 0.31.0 in <a href="https://redirect.github.com/docker/build-push-action/pull/1171">docker/build-push-action#1171</a> <a href="https://redirect.github.com/docker/build-push-action/pull/1159">docker/build-push-action#1159</a> <a href="https://redirect.github.com/docker/build-push-action/pull/1169">docker/build-push-action#1169</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/docker/build-push-action/compare/v6.2.0...v6.3.0">https://github.com/docker/build-push-action/compare/v6.2.0...v6.3.0</a></p> <h2>v6.2.0</h2> <ul> <li>Use default retention days for build export artifact by <a href="https://github.com/crazy-max"><code>@crazy-max</code></a> in <a href="https://redirect.github.com/docker/build-push-action/pull/1153">docker/build-push-action#1153</a></li> <li>Bump <code>@docker/actions-toolkit</code> from 0.27.0 to 0.28.0 in <a href="https://redirect.github.com/docker/build-push-action/pull/1158">docker/build-push-action#1158</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/docker/build-push-action/compare/v6.1.0...v6.2.0">https://github.com/docker/build-push-action/compare/v6.1.0...v6.2.0</a></p> <h2>v6.1.0</h2> <ul> <li>Bump <code>@docker/actions-toolkit</code> from 0.26.2 to 0.27.0 in <a href="https://redirect.github.com/docker/build-push-action/pull/1149">docker/build-push-action#1149</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/docker/build-push-action/compare/v6.0.2...v6.1.0">https://github.com/docker/build-push-action/compare/v6.0.2...v6.1.0</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/docker/build-push-action/commit/1a162644f9a7e87d8f4b053101d1d9a712edc18c"><code>1a16264</code></a> Merge pull request <a href="https://redirect.github.com/docker/build-push-action/issues/1172">#1172</a> from crazy-max/build-export-disable</li> <li><a href="https://github.com/docker/build-push-action/commit/9eea5481959e459ec651b7e822a59ca2589d7eeb"><code>9eea548</code></a> chore: update generated content</li> <li><a href="https://github.com/docker/build-push-action/commit/11c2faaa9eaca329b60ac7e06d5b0a39bb83ceee"><code>11c2faa</code></a> rename DOCKER_BUILD_EXPORT_RETENTION_DAYS to DOCKER_BUILD_RECORD_RETENTION_DAYS</li> <li><a href="https://github.com/docker/build-push-action/commit/de2365af33b297214817371552545c663ca68972"><code>de2365a</code></a> opt to disable build record upload</li> <li><a href="https://github.com/docker/build-push-action/commit/bca5082da7f40c0685bc546726266df13a2f9f4b"><code>bca5082</code></a> Merge pull request <a href="https://redirect.github.com/docker/build-push-action/issues/1173">#1173</a> from crazy-max/build-summary-env-change</li> <li><a href="https://github.com/docker/build-push-action/commit/e7aab408d9276621021be0d58bf5cc6eefc65a64"><code>e7aab40</code></a> chore: update generated content</li> <li><a href="https://github.com/docker/build-push-action/commit/63eb7590c6ed8db55bbbcb073d24d65171303129"><code>63eb759</code></a> switch DOCKER_BUILD_SUMMARY_DISABLE to DOCKER_BUILD_SUMMARY</li> <li><a href="https://github.com/docker/build-push-action/commit/53ec48606f270c370d678a3fbd9ab27117ba8cfd"><code>53ec486</code></a> Merge pull request <a href="https://redirect.github.com/docker/build-push-action/issues/1171">#1171</a> from docker/dependabot/npm_and_yarn/docker/actions-t...</li> <li><a href="https://github.com/docker/build-push-action/commit/fe9d9f1d0c920806ce6c73b48d1b95bc542ccbbb"><code>fe9d9f1</code></a> chore: update generated content</li> <li><a href="https://github.com/docker/build-push-action/commit/ad37ba1ad00503d50aa7b3835d3ac83f4372c199"><code>ad37ba1</code></a> chore(deps): Bump <code>@docker/actions-toolkit</code> from 0.30.0 to 0.31.0</li> <li>Additional commits viewable in <a href="https://github.com/docker/build-push-action/compare/v6.0.2...v6.3.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=docker/build-push-action&package-manager=github_actions&previous-version=6.0.2&new-version=6.3.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Cody Balos <[email protected]>
Add codespell workflow to CI to check for common spelling errors --------- Co-authored-by: Daniel R. Reynolds <[email protected]>
View of the rendered markdown: https://github.com/LLNL/sundials/blob/maintenance/readme/README.md --------- Co-authored-by: David Gardner <[email protected]>
Remove usage of print_warning macro that was missed previously --------- Co-authored-by: David Gardner <[email protected]>
Allow CMake to automatically determine `CMAKE_CUDA_ARCHITECTURES` if it is not set rather than defaulting to `70`
Correct ERKStep to MRIStep or SPRKStep
The `test_sundials_errors` test was failing for me which I traced down to the handling of variable arguments. It's the same issue discussed in #461 which was partially fixed in #462. This PR should finish it off. --------- Co-authored-by: Cody Balos <[email protected]> Co-authored-by: David Gardner <[email protected]>
Update this documentation for `MRIStepSetOrder` from #439 where low order methods were added
Update testing with Jenkins * New TPL versions * Address warnings with RAJA 2024+, Ginkgo 1.8.0 and 1.7.0, KLU 6+ * Update hypre examples to work with v2.20.0+ * Use Trilinos imported targets (added in v14.0.0) * Fix output file name collisions with ARKODE RAJA example * Fix warnings with gcc 11.4.1 * Fix Trilinos vector interface build with CUDA * Update output files --------- Co-authored-by: Cody Balos <[email protected]> Co-authored-by: Daniel R. Reynolds <[email protected]>
Issue a warning message rather than an error when an invalid order is selected in ARKODE.
Updated stepper `SetDefaults` routines to deallocate pre-existing structures before nullifying, and moved initial creation of the `SUNAdaptController` into stepper `SetDefaults` routines instead of `arkCreate`. This allows non-adaptive steppers to leave the SUNAdaptController object unallocated. --------- Co-authored-by: Steven Roberts <[email protected]> Co-authored-by: David Gardner <[email protected]>
Fix the checks in `sundials_add_test` to work correctly when a single command line input for a test is provided and the input corresponds to a false value in CMake. --------- Co-authored-by: Cody Balos <[email protected]>
The docs state that if a value hscale<=0 is specified, the default of 1.0 will be used.
This copies (with updates of outdated info) https://computing.llnl.gov/projects/sundials/faq to our online documentation. --------- Co-authored-by: David Gardner <[email protected]>
1. Use `LAPACK::LAPACK` rather than `LAPACK_LIBRARIES` 2. Simplify `try_compile` test 3. Don't overwrite `LAPACK_WORKS` (test every configuration pass) 4. Use `CHECK_START`, `CHECK_PASSED`, and `CHECK_FAILED` messages in compile test 5. Replace manual include guard with `include_guard(GLOBAL)` 6. Update `SundialsTPL.cmake.template` with above changes --------- Co-authored-by: Cody Balos <[email protected]>
Fix small typo in FAQ
Fixes a CMake configuration issue related to aliasing an ``ALIAS`` target when using ``ENABLE_KLU=ON`` in combination with a static-only build of SuiteSparse. See #579 for details. Fixes #579. --------- Signed-off-by: Daniel Weindl <[email protected]> Co-authored-by: Daniel R. Reynolds <[email protected]>
Comment `/autofix` on your PR and a GitHub action will fix the spelling, formatting, and swig errors.
Tell dependabot to target develop instead of `main`
Fix indentation so the ordered list is enumerated correctly
Fixes #581 The new implementation eliminates all temporary storage/mallocs and only traverses the matrix entries once when diagonal elements don't need to be added. The sparse matrix example shows about a 1.5x speedup on 50000x50000 matrices.
Add LSRKStep module to ARKODE with RKC, RKL, and SSPs methods. --------- Co-authored-by: Daniel R. Reynolds <[email protected]> Co-authored-by: David Gardner <[email protected]>
Add SUNStepper class for evolving IVPs --------- Co-authored-by: Steven Roberts <[email protected]> Co-authored-by: David Gardner <[email protected]> Co-authored-by: Daniel R. Reynolds <[email protected]>
Non-`SUNDIALS` namespaced variables may be used by other projects so don't `unset` them. Fixes #538 --------- Signed-off-by: Peter Hill <[email protected]> Co-authored-by: Cody Balos <[email protected]>
Bumps docker/build-push-action from 6.0.2 to 6.10.0. ---------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Cody Balos <[email protected]> Co-authored-by: David Gardner <[email protected]>
Updated CMake to prohibit CUDA interfaces when sunrealtype is set to extended precision. Currently, this configuration just results in build failures later on, so this PR heads this off with a clear error message.
Add slow time scale adaptivity to MRI-GARK methods Add adaptive MRI-SR and MERK methods --------- Co-authored-by: David J. Gardner <[email protected]> Co-authored-by: Steven Roberts <[email protected]>
Uninitialized variable caught with valgrind.
Add acknowledgements to README and online docs landing page
Add new warnings flags for gcc and clang. --------- Co-authored-by: David Gardner <[email protected]>
Add operator splitting stepper module to ARKODE ----- Co-authored-by: David Gardner <[email protected]> Co-authored-by: Daniel R. Reynolds <[email protected]> Co-authored-by: Cody Balos <[email protected]> Co-authored-by: Balos, Cody, J <[email protected]>
Fix out of bounds read when setting MRI stage type
* Fix memory leak when attaching an H-Tol controller to MRIStep * Fix memory leak / out of bound array access in Lagrange interpolation module * Fix memory leaks in unit tests
Fix a bug in SPRKStep where `yerr` was not initialized to zero when using compensated summations
Add missing 32-bit ``sunindextype`` Fortran interface functions for * ``N_VGetSubvectorArrayPointer_ManyVector`` * ``N_VGetSubvectorArrayPointer_MPIManyVector`` * ``SUNBandMatrix_Column`` * ``SUNDenseMatrix_Column``
Fix a bug when enabling rootfinding with fixed step sizes and the initial value of the rootfinding function is zero. In this case, uninitialized right-hand side data (`fn`) is used to compute a forward Euler step to get a state near the initial condition to determine if any rootfinding functions are active at the initial condition.
Fix dissipated entropy example: * Vector and matrix size * Initial condition * Answer function --------- Co-authored-by: Cody Balos <[email protected]>
Add test without TPLs to run CI with the address sanitizer enabled --------- Co-authored-by: Cody Balos <[email protected]>
Update set function name to be consistent with `SetNum` naming convention
Fix SYCL vector build with 2025 oneAPI compilers. Fix for #596 --------- Co-authored-by: David Gardner <[email protected]>
Follow on to utilities added in #499 * Make info logging output in the integrators more consistent * Update parser for MRI and operator splitting methods * Add function to extract lists of data for plotting * Add example scripts using log parser --------- Co-authored-by: Steven Roberts <[email protected]> Co-authored-by: Daniel R. Reynolds <[email protected]> Co-authored-by: Cody Balos <[email protected]>
SUNDIALS Release v7.2.0
gardner48
requested review from
balos1,
cswoodward and
drreynolds
as code owners
December 11, 2024 15:31
balos1
approved these changes
Dec 11, 2024
gardner48
changed the title
Release: 7.1.1 sync main with develop
Release: 7.2.0 sync main with develop
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUNDIALS Release v7.2.0 sync main with develop