-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added NodeList index to DataBase #313
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine. A heads up for the future -- I've been slowly transitioning things like this from int to size_t, which I now know is the more appropriate type for sizes and indices into containers like this. The int here is fine for now though, and consistent with the other things that return int's in the DataBase interface.
That MR is pointing at this one already. We should wait until that one is ready in case I need to make other changes. |
This lets us calculate the index in the
DataBase
that represents a givenNodeList
in the connectivity.ToDo :
RELEASE_NOTES.md
with notable changes.