Add example Flux jobscripts #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: there is no SCR batch job script for Flux. Add one.
Problem: the jobscript documentation does not mention `scr_flux_run`. Add a line describing it.
Problem: there is no example job script for running under Flux and recovering from node failures. Add one.
Problem: there is no documentation for the `scr_flux_run_loop.sh` example script. Mention it in the jobscripts README.
jameshcorbett
force-pushed
the
flux-jobscripts
branch
from
ec1f9ff
to
03484f3
Compare
Problem: the Flux ResourceManager subclass returns a list of strings from the 'down_nodes' method but the expected return value is a mapping from strings (hostnames) to strings giving a reason for why the node is down. Return a mapping, as expected.
|
Ok it took a lot of trial and error (some nodes just wouldn't die on command) but I finally got a solid test of this and it seems to work! Ready for review now @mcfadden8 |
mcfadden8
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #553, there are no flux jobscripts. Add them.
[WIP until I can test thoroughly.]