Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

venado system specs #548

Draft
wants to merge 14 commits into
base: develop
Choose a base branch
from
Draft

venado system specs #548

wants to merge 14 commits into from

Conversation

rfhaque
Copy link
Collaborator

@rfhaque rfhaque commented Jan 15, 2025

Description

This PR adds the system config specs for the LANL Venado system.

  1. saxpy errors out since CUDA 12.5 does not support clang 18 as the host compiler. Adding "-allow-unsupported-compiler" does not work (or the flag isn't begin added correctly by spack)
  2. caliper fails when apply a patch for the aarch64 architecture in spack

Dependencies: FIXME:Add a list of any dependencies.

Fixes issue(s): FIXME:Add list of relevant issues.

Type of Change

  • {x} Adding a system, benchmark, or experiment
  • { } Modifying an existing system, benchmark, or experiment
  • { } Documentation update
  • { } Build/CI update
  • { } Benchpark core functionality

Checklist:

If adding/modifying a system:

  • { } Create a new directory for the system and a new system.py file
  • { } Add a new dry run unit test in .github/workflows
  • { } System appears in System Specifications table in docs catalogue section

If adding/modifying a benchpark:

  • { } Add a new application.py and (maybe) package.py under a new directory
    for this benchmark
  • { } Configure an experiment
  • { } Benchmark appears in Benchmarks and Experiments table in docs catalogue
    section

If adding/modifying a experiment:

  • { } Extend experiment.py under existing directory for specific benchmark
  • { } Define a single node and multi-node experiments

If adding/modifying core functionality:

  • { } Update docs
  • { } Update .github/workflows and .gitlab/ci unit tests (if needed)

@rfhaque rfhaque requested review from scheibelp and pearce8 January 15, 2025 18:14
@github-actions github-actions bot added the application New or modified application label Jan 15, 2025
@pearce8
Copy link
Collaborator

pearce8 commented Jan 15, 2025

@rfhaque where is the PR checklist template? Those are helpful for reviewing. In particular, for adding a new system, we also need:
{ } Add a human-readable system description to systems/all_system_definitions
{ } Verify info added in all_system_definitions generates a new system column in Catalogue/System Specifications (https://software.llnl.gov/benchpark/system-list.html)
{ } Add a dry run of an existing benchmark using the new system definition

(@slabasan, if those are not listed in the PR template right now, we probably want to add them)

@pearce8 pearce8 requested a review from slabasan January 15, 2025 20:49
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daboehme Can you please see the patch for Caliper on Arm? We are working with a Grace Hopper machine. It would be great if you can fix this in Caliper and put up a PR to benchpark to remove the patch (if this PR is already merged).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be fixed in Caliper v2.12.1, which is the current default in upstream spack

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daboehme thanks!

@rfhaque are you using the tip of develop of Caliper which should be v2.12.1?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also this patch @daboehme

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one was only required in v2.9.0, which is quite outdated at this point

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rfhaque can you please remove the patches and use the newest Caliper instead? Is there a reason you are not doing so?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pearce8 This is just a temporary fix, till we pin the latest spack version.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rfhaque What is different about this spack package from upstream? We need to work with @dbo to review/upstream it.

}


class LanlVenado(System):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rfhaque Do they call them "clusters" or "partitions"? Do you also need to set "partition" in the slurm script to correspond to which partition of the machine you are wanting to use?

@alexrlongne might know.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pearce8 While technically these are hardware partitions, venado slurm defines its own "partitions" (standard, debug, gpu etc) corresponding to some set of resources/qos

return {
"cuda_arch": "90",
"default_cuda_version": self.spec.variants["cuda"][0],
"extra_batch_opts": '"-A llnl_ai_g -pgpu"',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rfhaque what does this extra_batch_opts do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
application New or modified application
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants