osu-microbenchmarks: rewrite as experiment.py file #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
becker33
reviewed
Aug 30, 2024
There was a problem hiding this comment.
What is the purpose of the programming_model variant for this experiment?
I think the scaling nodes could also be turned into a variant, maybe @nhanford can chime in on whether that's worth doing.
Otherwise this looks good to me.
|
Also need to add a dry-run. |
pearce8
approved these changes
Nov 13, 2024
pearce8
requested changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding osu-microbenchmarks experiment.py file.