Contact 페이지 오브젝트 이미지 애니메이션 구현
#68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chlqhgus
requested review from
rmdnps10,
shu07002,
Kimbyul88,
minwoooya and
seoooa
as code owners
chlqhgus
changed the title
Contact 페이지 오브젝트 이미지 애니메이션 구현
rmdnps10
reviewed
Oct 15, 2024
There was a problem hiding this comment.
useSequencialAnimation.ts를 통해 애니메이션 로직을 잘 분리하신 거 같습니다:)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
✨ 현재 작업은 어떤 이슈를 해결한 것인가요?
기존 코드에서 변경된 사항
애니메이션은 마음에 들 때까지...좀 만져보려고 합니다. 현재는 Fade-in으로 떠오르는 효과입니다.
tailwind.config.ts에
fadeinObject이라는 애니메이션을 추가한 상태입니다!이걸 사용하려고 했는데 delay를 어떻게 적용해야 할 지 모르겠어서 현재 custom hook을 사용했습니다...
가독성이 좀 별로인 것 같아 좀 더 수정해보겠습니다.