fix(module-federation): host with no remotes should not build remote …

…apps (nrwl#20283)
LHBruneton-C2C · Nov 21, 2023 · 2354577 · 2354577
1 parent 82b39d1
commit 2354577
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/...es/angular/src/builders/module-federation-dev-server/module-federation-dev-server.impl.ts b/...es/angular/src/builders/module-federation-dev-server/module-federation-dev-server.impl.ts
@@ -37,6 +37,9 @@ function buildStaticRemotes(
   context: import('@angular-devkit/architect').BuilderContext,
   options: Schema
 ) {
+  if (!remotes.staticRemotes.length) {
+    return Promise.resolve();
+  }
   const mappedLocationOfRemotes: Record<string, string> = {};
   for (const app of remotes.staticRemotes) {
     mappedLocationOfRemotes[app] = `http${options.ssl ? 's' : ''}://${

diff --git a/...ges/react/src/executors/module-federation-dev-server/module-federation-dev-server.impl.ts b/...ges/react/src/executors/module-federation-dev-server/module-federation-dev-server.impl.ts
@@ -147,6 +147,9 @@ async function buildStaticRemotes(
   context: ExecutorContext,
   options: ModuleFederationDevServerOptions
 ) {
+  if (!remotes.staticRemotes.length) {
+    return;
+  }
   logger.info(`NX Building ${remotes.staticRemotes.length} static remotes...`);
   const mappedLocationOfRemotes: Record<string, string> = {};