-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read and process file line by line #1
base: master
Are you sure you want to change the base?
Conversation
f001a65
to
57fcc52
Compare
57fcc52
to
87ded5b
Compare
Copying is an art of love. Please copy and share.
Hi, thank you for your PR. The LGBT-CN SC is designed for a trust box rather than a black box, i.e., we have 2 foundamental assumptions:
If you dont mind, please explain what this PR can improve, this will help. Thanks again for your PR. |
Thanks for your review. I am happy to draft this pull request. You are right. I have include unnecessary checks and use an unnecessary buffer. It may work better without these changes. I reviewed the commit history and I have a question: Why did you rewrite the signature-counter (Rust) in Go? |
I am not familiar with Rust. We met an unexpected behaviour with the previous SC (Signature Counter), and I cannot debug the programme with 瞪眼法. So we decided to convert it to Go with a much reliable approach (reliable means if not works, it will panic or broken, which will fail the CI). |
I will draft this PR for a while. I'll rethink this PR when Im free. |
Rewrite signature counter.
Some Specific Rules
Signature count was considered zero when missing signature block.
Learn more rules from unit tests.
Breaking Changes
HTML comments should be placed on standalone lines.
Ok:
Wrong:
Thanks for all amazing work in LGBTQIA In China.
Feel free to adjust any part of this pull request.