fix: vnext schema refs #185
Conversation
| @@ -426,6 +429,8 @@ public string Load(string reference) | |||
| userName: | |||
| description: User name. | |||
| type: string | |||
| orderHistory: | |||
| $ref: '#/components/OrderHistory' | |||
There was a problem hiding this comment.
these component refs are wrong.
its usually #/components/{componentType}/{refId}, which also means the components object is technically invalid in this test.
There was a problem hiding this comment.
Thanks @VisualBean I've updated with valid componentType object now I think. It's still not resolving though so I think the initial thought about internals not being resolved in externals is still valid.
There was a problem hiding this comment.
Ive debugged through it, and it seems to stem from the externalReferenceResolver.
Basically when the external reference is loaded, the subreferences are internal. So the ResolveReference method simply returns null.
if (reference.IsExternal)
{
...
return externalAsyncApiContent;
}
return null;
So - hopefully my referenceresolution followup PR will fix it.
VisualBean
force-pushed
the
vnext
branch
2 times, most recently
from
5d95d59
to
a9d501d
Compare
About the PR
Some tests