Ilo #74
Open
Ilo #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
April 25, 2023 11:23
ebezzam
reviewed
Aug 2, 2023
|
|
||
|
|
||
| def get_landmark(filepath): | ||
| """get landmark with dlib |
There was a problem hiding this comment.
docstrings consistent with other files
ebezzam
reviewed
Aug 2, 2023
|
|
||
| def align_face(filepath): | ||
| """ | ||
| :param filepath: str |
There was a problem hiding this comment.
docstrings consistent with other files
ebezzam
reviewed
Aug 2, 2023
lensless/utils/align_face.py
Outdated
|
|
||
| lm = get_landmark(filepath) | ||
|
|
||
| # lm_chin = lm[0:17] # left-right |
There was a problem hiding this comment.
remove commented code that isn't needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a pull request (PR)! Before hitting the submit button, we would be really glad if you check all the following points. Even if you can't check all the boxes below, do not hesitate to go ahead with the PR and ask for help there.
Please also refer to the doc on contributing for more details.
pytestfrom the repository root? See the documentation for more details.Happy PR 😃