Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plug-and-play #111

Closed
wants to merge 12 commits into from
Closed

Conversation

ebezzam
Copy link
Member

@ebezzam ebezzam commented Jan 23, 2024

Thank you for submitting a pull request (PR)! Before hitting the submit button, we would be really glad if you check all the following points. Even if you can't check all the boxes below, do not hesitate to go ahead with the PR and ask for help there.

Please also refer to the doc on contributing for more details.

  • Have you run the tests by running pytest from the repository root? See the documentation for more details.
  • Do you follow the code formatting for this project? This can be done by setting up pre-commit hooks as described in the documentation.
  • Is there a unit test for the proposed code modification? If the PR addresses an issue, the test should make sure the issue is fixed.
  • Are there docstrings? Do they follow the numpydoc style?
  • Have you checked that the doc builds properly and that any new RST file has been added to the repo? How to do that is covered in the documentation.
  • Did you document the proposed change(s) in the CHANGELOG file? It should go under "Unreleased".

Happy PR 😃

(cherry picked from commit 8976a186b00b23d25805deef60a5957cd616cd0b)
(cherry picked from commit 9c3d210a6a30ed990aeb139f7d4be814a2b88dad)
(cherry picked from commit ba992127751949739d6865e4ece80e0d922dde68)
(cherry picked from commit d724301f880e75faa7ac549ac7ea4201cb75ca78)
@ebezzam
Copy link
Member Author

ebezzam commented Feb 8, 2024

plug-and-play integrated with #109

@ebezzam ebezzam closed this Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants