openapi からprotoに変更 #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
K-Kizuku
requested changes
Apr 9, 2024
Makefile
Outdated
| @@ -4,6 +4,7 @@ PROTO_FILES = $(shell find ./proto/schema -name "*.proto" -type f) | |||
| build: | |||
| rm -rf openapi | |||
| mkdir openapi | |||
| protoc -I. --plugin=./protoc-plugin/protoc-gen-ts-msw-handlers/protoc-gen-ts-msw-handlers --ts-msw-handlers_out=./msw ./proto/schema/**/*.proto | |||
msw/types/index.ts
Outdated
| } | ||
| export type GetUserWorksRequest = { | ||
| userId: string; | ||
| vislibility: string; |
| export type GetUserWorksRequest = { | ||
| userId: string; | ||
| vislibility: string; | ||
| newestUserId: string; |
There was a problem hiding this comment.
newestよりlatestの方が自然ではある(けど多分ここですべきレビューではない)
|
|
||
| option go_package = "./"; | ||
| enum AssetType { | ||
| zip = 0; |
There was a problem hiding this comment.
protoでは0に意味のある値を持たせないことが多いから0はUNKNOWNくらいにしておくのが一般的
| } | ||
|
|
||
| message DeleteAssetResponse { | ||
| string status =1; |
There was a problem hiding this comment.
Suggested change
| string status =1; | |
| string status = 1; |
リンターがうまく働いてない？
|
|
||
| message GetUserWorksRequest{ | ||
| string user_id = 1; | ||
| string vislibility = 2; |
K-Kizuku
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
実装内容
全APIをprotoに変更
protoc pluginによるmsw handlerの生成