Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add eslint rule of React import #66

Merged
merged 1 commit into from
Nov 5, 2023
Merged

chore: add eslint rule of React import #66

merged 1 commit into from
Nov 5, 2023

Conversation

tosaken1116
Copy link
Collaborator

issue番号

closes #65

変更点概要

eslint ruleを新たに追加

  • Reactの明示的importを禁止

参考文献(あれば)

スクリーンショット(必要であれば)

チェック項目

  • テストが通ったか
  • ビルドが通ったか
  • self assignしたか
  • レビュー優先度のラベルをつけたか

@tosaken1116 tosaken1116 self-assigned this Nov 5, 2023
K-Kizuku
K-Kizuku approved these changes Nov 5, 2023
View reviewed changes
Copy link
Collaborator

@K-Kizuku K-Kizuku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK!!

@tosaken1116 tosaken1116 merged commit 00c6286 into develop Nov 5, 2023
3 checks passed
@tosaken1116 tosaken1116 deleted the chore/react-import-eslint-rule-#65 branch November 5, 2023 17:17
@tosaken1116 tosaken1116 restored the chore/react-import-eslint-rule-#65 branch November 5, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@K-Kizuku K-Kizuku K-Kizuku approved these changes

@PigeonsHouse PigeonsHouse Awaiting requested review from PigeonsHouse

Assignees

@tosaken1116 tosaken1116

Labels
priority low
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

react eslint rule
2 participants
@tosaken1116 @K-Kizuku