Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.0.3 #169

Closed
wants to merge 10 commits into from
Closed

v2.0.3 #169

wants to merge 10 commits into from

Conversation

JaredBorders
Copy link
Contributor

@JaredBorders JaredBorders commented Jun 22, 2023

v2.0.3

Major Changes

  • Add UNISWAP_V3_SWAP command for token swaps (sUSD <-> token)
    • Update Settings.sol to include a whitelisting capability
  • Add PERMIT2_PERMIT command for signature-based token approvals
  • Update _modifyAccountMargin to use Permit2 for token transfers into the SM account
  • Add reentrancy guard to _dispatch()

Minor Changes

  • Update Foundry
    • Remove most gitmodules (solmate, etc.)
    • Refactor imports in script/, src/, and test/
  • Add new events for token swaps
  • Test all Major Changes and new events
  • Update deploy script
  • Add upgrade script
  • Remove coverage checking due to foundry-based issues around optimizations during forge coverage execution

closes #168

@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Merging #169 (532285e) into main (36b0491) will decrease coverage by 5.89%.
The diff coverage is 65.62%.

❗ Current head 532285e differs from pull request most recent head 8a8027b. Consider uploading reports for the commit 8a8027b to get more accurate results

@@            Coverage Diff             @@
##             main     #169      +/-   ##
==========================================
- Coverage   95.34%   89.45%   -5.89%     
==========================================
  Files           8       11       +3     
  Lines         279      332      +53     
  Branches       56       63       +7     
==========================================
+ Hits          266      297      +31     
- Misses          2       23      +21     
- Partials       11       12       +1     
Impacted Files Coverage Δ
src/Factory.sol 92.59% <ø> (ø)
src/utils/uniswap/BytesLib.sol 0.00% <0.00%> (ø)
src/utils/uniswap/SafeCast160.sol 0.00% <0.00%> (ø)
src/utils/uniswap/V3Path.sol 0.00% <0.00%> (ø)
src/Account.sol 95.90% <92.30%> (-0.83%) ⬇️
src/Events.sol 100.00% <100.00%> (ø)
src/Settings.sol 100.00% <100.00%> (ø)
src/utils/Owned.sol 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@JaredBorders JaredBorders marked this pull request as ready for review July 5, 2023 21:40
@JaredBorders JaredBorders self-assigned this Jul 5, 2023
@JaredBorders JaredBorders changed the title V2.0.3 v2.0.3 Jul 6, 2023
src/Account.sol Outdated Show resolved Hide resolved
src/Account.sol Outdated Show resolved Hide resolved
src/Account.sol Outdated Show resolved Hide resolved
src/Account.sol Outdated Show resolved Hide resolved
src/Account.sol Outdated Show resolved Hide resolved
src/Settings.sol Outdated Show resolved Hide resolved
src/Account.sol Outdated Show resolved Hide resolved
src/Account.sol Outdated Show resolved Hide resolved
src/Account.sol Outdated Show resolved Hide resolved
src/Account.sol Outdated Show resolved Hide resolved
Copy link
Contributor

@tommyrharper tommyrharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great upgrade - super cool what can be done with Permit2 🔥

Brought up a few things, nothing major, let me know your thoughts 👌

@JaredBorders
Copy link
Contributor Author

This is a great upgrade - super cool what can be done with Permit2 🔥

Brought up a few things, nothing major, let me know your thoughts 👌

Okay addresses everything one way or another. Lmk what you think

@JaredBorders JaredBorders changed the base branch from main to v2.1.0 July 17, 2023 21:14
@JaredBorders JaredBorders deleted the branch v2.1.0 July 17, 2023 21:15
@JaredBorders JaredBorders deleted the v2.0.3 branch July 17, 2023 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Any ERC20 to sUSD command
2 participants