Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add KubeScanner definition and implement #95

Merged
merged 3 commits into from
Dec 6, 2023

Conversation

elliotxx
Copy link
Collaborator

@elliotxx elliotxx commented Dec 5, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add scanner definition and implement, including:

  • Add KubeScanner definition
  • Using kubeaudit to implement KubeScanner
  • Add unit tests

@elliotxx elliotxx self-assigned this Dec 5, 2023
@elliotxx elliotxx requested a review from adohe as a code owner December 5, 2023 13:56
@elliotxx elliotxx changed the title feat: add scanner definition and implement feat: add KubeScanner definition and implement Dec 5, 2023
@elliotxx elliotxx changed the title feat: add KubeScanner definition and implement [WIP] feat: add KubeScanner definition and implement Dec 5, 2023
@elliotxx elliotxx added this to the v0.3.0 milestone Dec 6, 2023
@elliotxx elliotxx linked an issue Dec 6, 2023 that may be closed by this pull request
@elliotxx elliotxx changed the title [WIP] feat: add KubeScanner definition and implement feat: add KubeScanner definition and implement Dec 6, 2023
panshuai111
panshuai111 previously approved these changes Dec 6, 2023
Copy link
Collaborator

@panshuai111 panshuai111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@ffforest ffforest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@elliotxx elliotxx merged commit 084dc9f into main Dec 6, 2023
7 checks passed
@elliotxx elliotxx deleted the add-scanner-implement branch December 6, 2023 14:55
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2023
@ffforest ffforest linked an issue Dec 13, 2023 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Insight: Resource and Aggregated Scoring API Insight: Add issue-based scanning using kubeaudit
3 participants