Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
In the current implementation, the lifecycle of storage data is bound to object in cluster. When an object is deleted in cluster, the associated data in storage will also be cleared.
Events in cluster are retained for one hour by default. As key information for troubleshooting, it is usually hoped that events can be retained for a longer time, which requires karpor to unbind the lifecycle of specific types of resources from cluster.
This PR adds a
remainAfterDeleted
field in the SyncRegistry CRD to control that a certain type of resources remain in storage after being deleted in cluster.If the user sets
remainAfterDeleted=true
for a type of resource, the user needs to delete the associated data in the storage by himself. Karpor only marksdeleted=true
for storage data when the object is deleted in cluster.For resources that leave
remainAfterDeleted
unset (remainAfterDeleted=false
), the data in storage will be deleted immediately after the cluster object is deleted.Which issue(s) this PR fixes:
Fixes #