Skip to content

Commit

Permalink
chore: adjust pull request constraints (#71)
Browse files Browse the repository at this point in the history
## What type of PR is this?
/kind chore

## What this PR does / why we need it:
Adjust pull request constraints
  • Loading branch information
elliotxx authored Aug 3, 2023
1 parent 68d3eda commit 46b4f7f
Show file tree
Hide file tree
Showing 2 changed files with 41 additions and 34 deletions.
34 changes: 0 additions & 34 deletions .github/workflows/check.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -52,40 +52,6 @@ jobs:
# Optional: version of golangci-lint to use in form of v1.2 or v1.2.3 or `latest` to use the latest version
version: v1.52.2

# Lints Pull Request commits with commitlint.
#
# Rules can be referenced:
# https://github.com/conventional-changelog/commitlint/tree/master/%40commitlint/config-conventional
CommitLint:
name: Commit Lint
runs-on: ubuntu-latest
if: contains(fromJSON('["pull_request"]'), github.event_name)
steps:
- name: Checkout
uses: actions/checkout@v3
with:
fetch-depth: 0
- uses: wagoid/commitlint-github-action@v5

# Lints Pull Request title, because the title will be used as the
# commit message in branch main.
#
# Configuration detail can be referenced:
# https://github.com/marketplace/actions/pull-request-title-rules
PullRequestTitleLint:
name: Pull Request Title Lint
runs-on: ubuntu-latest
if: contains(fromJSON('["pull_request"]'), github.event_name)
steps:
- uses: deepakputhraya/action-pr-title@master
with:
allowed_prefixes: 'build,chore,ci,docs,feat,fix,perf,refactor,revert,style,test' # title should start with the given prefix
disallowed_prefixes: 'WIP,[WIP]' # title should not start with the given prefix
prefix_case_sensitive: false # title prefix are case insensitive
min_length: 5 # Min length of the title
max_length: 80 # Max length of the title
github_token: ${{ github.token }} # Default: ${{ github.token }}

LicenseCheck:
name: License Check
runs-on: ubuntu-latest
Expand Down
41 changes: 41 additions & 0 deletions .github/workflows/constraint.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
# Reference from:
# https://github.com/c-bata/go-prompt/blob/master/.github/workflows/test.yml
name: Constraints
on:
pull_request:
types: [opened, edited, synchronize, reopened]
jobs:
# Lints Pull Request commits with commitlint.
#
# Rules can be referenced:
# https://github.com/conventional-changelog/commitlint/tree/master/%40commitlint/config-conventional
CommitLint:
name: Commit Lint
runs-on: ubuntu-latest
if: contains(fromJSON('["pull_request"]'), github.event_name)
steps:
- name: Checkout
uses: actions/checkout@v3
with:
fetch-depth: 0
- uses: wagoid/commitlint-github-action@v5

# Lints Pull Request title, because the title will be used as the
# commit message in branch main.
#
# Configuration detail can be referenced:
# https://github.com/marketplace/actions/pull-request-title-rules
PullRequestTitleLint:
name: Pull Request Title Lint
runs-on: ubuntu-latest
if: contains(fromJSON('["pull_request"]'), github.event_name)
steps:
- uses: deepakputhraya/action-pr-title@master
with:
allowed_prefixes: 'build,chore,ci,docs,feat,fix,perf,refactor,revert,style,test' # title should start with the given prefix
disallowed_prefixes: 'WIP,[WIP]' # title should not start with the given prefix
prefix_case_sensitive: false # title prefix are case insensitive
min_length: 5 # Min length of the title
max_length: 80 # Max length of the title
github_token: ${{ github.token }} # Default: ${{ github.token }}

0 comments on commit 46b4f7f

Please sign in to comment.