Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes docs and clearer variable names #4

Closed
wants to merge 3 commits into from
Closed

Fixes docs and clearer variable names #4

wants to merge 3 commits into from

Conversation

felixsanz
Copy link

Updated the fields to match the code, they were wrong.

Also, fixed #2, since its not a connection but a rethinkdbdash instance.

@felixsanz
Fixed options fields
9b81973 
Updated the fields to match the code, they were wrong.
@felixsanz
Clear docs
20f4ac8 
Fixes #2, since its not a connection but a rethinkdbdash instance.
@felixsanz
Renaming connection to r instance
72d91c7 
Fixes #2, since its not a connection but a rethinkdbdash instance.
@felixsanz felixsanz changed the title Fixes docs and clear variable names Fixes docs and clearer variable names Aug 6, 2015
@sagivf
Copy link

sagivf commented Mar 13, 2016

+1 on this - It also helps avoiding the Warning: a promise was created in a handler but was not returned from it message.

@felixsanz felixsanz closed this Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation example is confusing
2 participants
@felixsanz @sagivf