Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests #54

Merged
merged 7 commits into from
Jun 6, 2024
Merged

Fix tests #54

merged 7 commits into from
Jun 6, 2024

Conversation

eguzki
Copy link
Contributor

@eguzki eguzki commented May 29, 2024

What

Fix broken tests since #49. That included more host calls that are not expected by the test framework.

Depends on Kuadrant/wasm-test-framework#3 (test will fail until PR is merged in the wasm-test-framework)

Additionally, create it's own GH actions workflow for tests. The existing workflow was running nightly basis and it was automatically disabled after 60 days of inactivity on the project.

@eguzki eguzki requested a review from alexsnaps May 29, 2024 16:29
@eguzki eguzki mentioned this pull request Jun 3, 2024
@eguzki eguzki marked this pull request as ready for review June 5, 2024 15:47
@eguzki eguzki requested a review from a team June 5, 2024 15:47
@eguzki
Copy link
Contributor Author

eguzki commented Jun 5, 2024

all green 🎉

@eguzki eguzki requested a review from didierofrivia June 6, 2024 09:29
Copy link
Contributor

@didierofrivia didierofrivia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe change the workflow event on push only to main branches and it´s good to go!

@eguzki eguzki merged commit fc12020 into main Jun 6, 2024
6 checks passed
@eguzki eguzki deleted the fix-tests branch June 6, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants