Run next action on failure when failuremode is allow #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…allow Signed-off-by: Eguzki Astiz Lezaun <[email protected]>
| @@ -1,6 +1,6 @@ | |||
| # This file is automatically @generated by Cargo. | |||
| # It is not intended for manual editing. | |||
| version = 3 | |||
| version = 4 | |||
There was a problem hiding this comment.
I think this is due to a newer cargo version as my local one doesn't support this, we are pinned at 1.75.0 for local development
rustup override set 1.75
Comment on lines
+141
to
+144
| Some(&[ | ||
| 10, 1, 97, 18, 28, 10, 26, 10, 21, 108, 105, 109, 105, 116, 95, 116, 111, 95, 98, | ||
| 101, 95, 97, 99, 116, 105, 118, 97, 116, 101, 100, 18, 1, 49, 24, 1, | ||
| ]), |
There was a problem hiding this comment.
Do we want to use Some vs None here and are the bytes here correct?
| .execute_and_expect(ReturnType::None) | ||
| .unwrap(); | ||
|
|
||
| let first_call_token_id = 42; |
There was a problem hiding this comment.
Should we just leave this out and have it hard-coded the same as the second token? or use a diff token than 42 for both?
There was a problem hiding this comment.
I would use a diff token, as this is the case when running on the host.
|
handed over to #158 |
eguzki
deleted the
149-failuremode-propagation-and-handling-in-services
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes #149