Subject access review tests #547
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Hesko <[email protected]>
2 tasks
averevki
reviewed
Oct 9, 2024
testsuite/kubernetes/cluster_role.py
Outdated
| cls, | ||
| cluster, | ||
| name, | ||
| rules: Optional[List[Dict[str, Any]]] = None, |
There was a problem hiding this comment.
Do you think it's possible to structure and pass these rules as a @dataclass? Or their structure is too complex?
There was a problem hiding this comment.
I experimented with this but due to the ClusterRole rules definition having so many parameters it's a problem not having them show up in the resulting object.
...e/tests/singlecluster/authorino/identity/subject_access_review/test_subject_access_review.py
Outdated
Show resolved
Hide resolved
...e/tests/singlecluster/authorino/identity/subject_access_review/test_subject_access_review.py
Outdated
Show resolved
Hide resolved
testsuite/tests/singlecluster/authorino/identity/subject_access_review/conftest.py
Show resolved
Hide resolved
jsmolar
reviewed
Oct 15, 2024
testsuite/tests/singlecluster/authorino/identity/subject_access_review/conftest.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Martin Hesko <[email protected]>
martinhesko
force-pushed
the
subject_access_review
branch
from
8143c68 to
028b4f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on User guide: Kubernetes RBAC for service authorization
Added the interface for ClusterRole and ClusterRoleBinding.
For the test I added TokenReview authentication and SubjectAccessReview based on the username.
The test setup creates 2 service accounts, with one bound to the ClusterRole permitting it to access the
/getendpoint.