Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gateway listener dns test #504

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Conversation

azgabur
Copy link
Contributor

@azgabur azgabur commented Aug 9, 2024

This PR addes new test that checks for this bug: Kuadrant/kuadrant-operator#794
Part of work on #308

@azgabur azgabur force-pushed the dnspolicy_gateway_test branch 2 times, most recently from 63c9c2c to 6debfd8 Compare August 9, 2024 15:27
testsuite/utils.py Outdated Show resolved Hide resolved
Copy link
Contributor

@averevki averevki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't get dnspolicy to the ready state before the test DNSPolicy has encountered some issues: reconcile DNSRecords error error reconciling dns records for gateway gw-averevki--g81o: DNSRecord.kuadrant.io "gw-averevki--g81o-api" is invalid: [spec.providerRef: Required value, <nil>: Invalid value: "null": some validation rules were not checked because the object was invalid; correct the existing errors to complete validation]

testsuite/utils.py Outdated Show resolved Hide resolved
testsuite/utils.py Outdated Show resolved Hide resolved
@azgabur azgabur added the Test case New test case label Aug 21, 2024
Copy link
Contributor

@trepel trepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I got it right this test covers what it is expected to cover. I tried to pause the test just before last assertion and removed the dnsbug1 records from AWS manually and the test passed then as expected. LGTM

@azgabur azgabur merged commit 06046af into Kuadrant:main Aug 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Test case New test case
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants