Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for limitador metrics #493

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Conversation

jsmolar
Copy link
Contributor

@jsmolar jsmolar commented Jul 25, 2024

No description provided.

@jsmolar jsmolar force-pushed the limitador_metrics branch 2 times, most recently from 6543ea9 to ca78b62 Compare July 26, 2024 09:05
trepel
trepel previously approved these changes Aug 29, 2024
Copy link
Contributor

@trepel trepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am far from being an expert on monitoring but the code looks good to me (just two minor comments) and the test passed. I also validated that the tests are skipped if monitoring is not enabled.

trepel
trepel previously approved these changes Aug 29, 2024
Copy link
Contributor

@trepel trepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now!

@jsmolar jsmolar merged commit b831e9f into Kuadrant:main Sep 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants