Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add has_dns_error() and has_tls_error() assert to mgc tests #259

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Add has_dns_error() and has_tls_error() assert to mgc tests #259

merged 1 commit into from
Nov 15, 2023

Conversation

pehala
Copy link
Contributor

@pehala pehala commented Nov 2, 2023

  • Add two new asserts to MGC tests, which ensure that in case of incorrect configuration or a bug, tests will Fail instead throwing and Exception
  • Rename our HttpX client to KuadrantClient

@pehala pehala requested review from jsmolar and ficap November 2, 2023 09:26
jsmolar
jsmolar reviewed Nov 8, 2023
View reviewed changes
testsuite/httpx/__init__.py Outdated Show resolved Hide resolved
jsmolar
jsmolar previously approved these changes Nov 13, 2023
View reviewed changes
jsmolar
jsmolar previously approved these changes Nov 15, 2023
View reviewed changes
@pehala pehala merged commit 09b32a5 into Kuadrant:main Nov 15, 2023
2 checks passed
@averevki averevki mentioned this pull request Nov 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ficap ficap ficap approved these changes

@jsmolar jsmolar jsmolar left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pehala @jsmolar @ficap