Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Authpolicy v1beta2 reformat #248

Merged
merged 3 commits into from
Oct 31, 2023
Merged

Authpolicy v1beta2 reformat #248

merged 3 commits into from
Oct 31, 2023

Conversation

azgabur
Copy link
Contributor

@azgabur azgabur commented Oct 23, 2023 •
edited
Loading

This PR makes this testsuite compatible with newest AuthConfig/AuthPolicy v1beta2

Few notes:

  • Envoy Dynamic Metadata function needs to be added in Responses section when tests for it will be created
    • Wristband tests are for now skipped!
  • Test for Custom deny code/body/headers need to be created
  • testsuite/tests/kuadrant/authorino/response/test_headers.py is maybe not needed as wrapperKey no longer exists or needs some rewrite

averevki
averevki reviewed Oct 24, 2023
View reviewed changes
Copy link
Contributor

@averevki averevki left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rhsso tests don't work on my machine (I don't know if they were working before 🙂)

#246

testsuite/tests/kuadrant/authorino/response/test_headers.py Show resolved Hide resolved
testsuite/openshift/objects/auth_config/sections.py Show resolved Hide resolved
testsuite/openshift/objects/auth_config/__init__.py Show resolved Hide resolved
@azgabur azgabur force-pushed the authpolicyv2 branch 3 times, most recently from 4673136 to 9cb8f26 Compare October 30, 2023 10:20
pehala
pehala previously approved these changes Oct 30, 2023
View reviewed changes
@pehala pehala requested a review from averevki October 30, 2023 10:32
@azgabur
Copy link
Contributor Author

azgabur commented Oct 30, 2023

^ Additional place for renamed Credentials locations I forgot about

@azgabur azgabur mentioned this pull request Oct 30, 2023
Merged
@pehala pehala merged commit 4a7b314 into Kuadrant:main Oct 31, 2023
2 checks passed
This was referenced Nov 2, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@averevki averevki averevki approved these changes

@pehala pehala pehala approved these changes

@jsmolar jsmolar Awaiting requested review from jsmolar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@azgabur @pehala @averevki