Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix metrics tests broken by reformat #241

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Fix metrics tests broken by reformat #241

merged 1 commit into from
Oct 16, 2023

Conversation

averevki
Copy link
Contributor

Were broken by #235 and #228

@averevki averevki requested a review from pehala October 13, 2023 14:37
@averevki averevki requested a review from azgabur October 13, 2023 16:40
jsmolar
jsmolar approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@jsmolar jsmolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing that I am scared of, is over-extending OpenShiftClient.

@pehala
Copy link
Contributor

pehala commented Oct 16, 2023

The only thing that I am scared of, is over-extending OpenShiftClient.

Agreed, I am fine with this particular method, but the alternative might be to move it to be a class method in OpenShiftRoute. @jsmolar WDYT?

@jsmolar
Copy link
Contributor

jsmolar commented Oct 16, 2023

The only thing that I am scared of, is over-extending OpenShiftClient.

Agreed, I am fine with this particular method, but the alternative might be to move it to be a class method in OpenShiftRoute. @jsmolar WDYT?

I don't like OpenShiftRoute either. The best place would be to get it straight from the service, but it is pointless to create such an object just for this. I am afraid I don't have an answer for this.

@pehala
Copy link
Contributor

pehala commented Oct 16, 2023

Merging for now, we might resolve this when we add a Service object.

@pehala pehala merged commit d5aff98 into Kuadrant:main Oct 16, 2023
2 checks passed
@averevki averevki deleted the fix-metrics-tests branch November 24, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azgabur azgabur azgabur approved these changes

@jsmolar jsmolar jsmolar approved these changes

@pehala pehala pehala approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@averevki @pehala @jsmolar @azgabur