Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reconciliation tests for DNSPolicy/TLSPolicy #239

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Add reconciliation tests for DNSPolicy/TLSPolicy #239

merged 1 commit into from
Feb 19, 2024

Conversation

pehala
Copy link
Contributor

@pehala pehala commented Oct 11, 2023

  • Tests for basic reconciliation scenarios for interactions between DNSPolicy and Gateway
  • Introduce wait_until function for OpenShiftObject

@pehala pehala requested a review from ficap October 11, 2023 12:42
@pehala pehala force-pushed the dns_reconciliation branch 2 times, most recently from 2cf6fe3 to 429c5b2 Compare October 12, 2023 10:16
@pehala pehala marked this pull request as draft October 26, 2023 15:54
@pehala pehala force-pushed the dns_reconciliation branch from 429c5b2 to 41b763d Compare February 7, 2024 09:29
@pehala pehala changed the title Add reconciliation tests for DNSPolicy Add reconciliation tests for DNSPolicy/TLSPolicy Feb 7, 2024
@pehala pehala requested review from jsmolar and ficap February 7, 2024 09:30
@pehala pehala marked this pull request as ready for review February 7, 2024 09:30
jsmolar
jsmolar previously approved these changes Feb 7, 2024
View reviewed changes
@pehala pehala force-pushed the dns_reconciliation branch from 41b763d to 7c7da8d Compare February 15, 2024 14:24
@pehala pehala requested review from jsmolar and averevki February 15, 2024 14:38
@pehala pehala force-pushed the dns_reconciliation branch 2 times, most recently from d4305f7 to 7db35a5 Compare February 15, 2024 15:00
averevki
averevki previously approved these changes Feb 15, 2024
View reviewed changes
@pehala pehala force-pushed the dns_reconciliation branch 2 times, most recently from a42f4ca to 354413c Compare February 19, 2024 12:37
@pehala pehala force-pushed the dns_reconciliation branch from 354413c to e4c465d Compare February 19, 2024 12:38
@pehala pehala requested a review from azgabur February 19, 2024 14:44
@pehala pehala merged commit 6a94d1f into Kuadrant:main Feb 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azgabur azgabur azgabur approved these changes

@averevki averevki averevki approved these changes

@ficap ficap Awaiting requested review from ficap

@jsmolar jsmolar Awaiting requested review from jsmolar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pehala @jsmolar @ficap @averevki @azgabur