This repository has been archived by the owner on Dec 16, 2024. It is now read-only.
#703: Re-add health check components #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-add health check monitor and queue, as well as reconciler to policy controller. These components were removed accidentally as part of the separation of controllers
sergioifg94
had a problem deploying
to
e2e-internal
GitHub Actions
Failure
sergioifg94
temporarily deployed
to
e2e-internal
GitHub Actions
Inactive
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maleck13, sergioifg94 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@sergioifg94 Do we not have any tests that check this? Maybe an e2e test that uses health checks in some way would be good to add? |
|
@mikenairn We only have integration tests and unfortunately they didn't catch this because the health check components didn't get deleted from the test suite. I agree we could use some e2e tests for it. I'll create an issue |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-add health check monitor and queue, as well as reconciler to policy controller. These components were removed accidentally as part of the separation of controllers
Verification steps
Run the local setup and include a health check section in the DNSPolicy
Verify that a DNSHealthCheckProbe is created and the status is updated