Fixing prompt text when asking for AWS credentials #705
Conversation
pmccarthy
temporarily deployed
to
e2e-internal
GitHub Actions
Inactive
hack/.quickstartEnv
Outdated
| read MGC_AWS_ACCESS_KEY_ID </dev/tty | ||
| echo "export MGC_AWS_ACCESS_KEY_ID for future executions of the script to skip this step" | ||
| fi | ||
|
|
||
| if [[ -z "${MGC_AWS_SECRET_ACCESS_KEY}" ]]; then | ||
| echo "Enter your AWS secret access key for an Account where you have access to Route53:" | ||
| echo "Enter an AWS secret access key for an Account where you have access to Route53:" |
There was a problem hiding this comment.
Is it clear that the secret access key has to be the one that pairs with the access key id entered before?
There was a problem hiding this comment.
That's a fair point. Let me clarify that a bit more
There was a problem hiding this comment.
@guicassolato wording updated now - mind taking another look please?
pmccarthy
force-pushed
the
quickstart_prompt_text
branch
from
ebb5dc5 to
07462be
Compare
pmccarthy
temporarily deployed
to
e2e-internal
GitHub Actions
Inactive
|
/lgtm |
|
@pmccarthy: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
/approve |
1 similar comment
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: david-martin, guicassolato, pmccarthy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary
Fixing the wording used in the quickstart prompts for AWS credentials. Current wording causes confusion as the term
secretis used for both the access key and secret key