Refactor metrics to use alternate metrics crate #301
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
I've removed the original prometheus crate and added metrics, and prometheus metrics exporter. These support using the metrics API, and the exporter allows us to get a handle to be able to still use actix to export the metrics at
/metrics
.describe_*
methods on initprometheus_metrics
struct is still passed toenvoy_rls/server
and to thehttp_api/server
to retain the configlimit_name_in_labels
for writing the metrics - not 100% sold on this solution thoughdatastore_partitioned
metric to the limitador libraryVerification
Checkout this branch and build server:
Run the server:
Check metrics endpoint:
TODO