AtomicExpiringValue #191
Merged
AtomicExpiringValue #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
didierofrivia
force-pushed
the
atomic-expiring-value
branch
from
8f811ba
to
65025f9
Compare
didierofrivia
force-pushed
the
atomic-expiring-value
branch
2 times, most recently
from
17626cc
to
53ae626
Compare
alexsnaps
reviewed
Jul 27, 2023
alexsnaps
reviewed
Jul 27, 2023
alexsnaps
reviewed
Jul 27, 2023
alexsnaps
reviewed
Jul 27, 2023
limitador/src/storage/in_memory.rs
Outdated
| // Update counters | ||
| counter_values_to_update | ||
| .iter() | ||
| .for_each(|(v, ttl)| v.update(delta, *ttl, now)); |
There was a problem hiding this comment.
This is only not racy right now because of the WriteLock acquired above.
Codecov Report
@@ Coverage Diff @@
## main #191 +/- ##
=======================================
Coverage ? 74.10%
=======================================
Files ? 30
Lines ? 4989
Branches ? 0
=======================================
Hits ? 3697
Misses ? 1292
Partials ? 0 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
* value and expiry are updated in different threads, not atomic per se
* Removing not used update_mut fn
* Also, updating value when checked and it has expired
* Also keeping `value_at` simpler
didierofrivia
force-pushed
the
atomic-expiring-value
branch
from
8bc47ee
to
dc98716
Compare
* Using thread.scope in order to get rid of Arc and Barrier * Fixing assertion to include possible accepted values
alexsnaps
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is one step closer to a multi-threading Limitador. It introduces the
AtomicExpiringValue, as the name suggests, an atomic alternative to theExpiringValuetype, at the moment used only inInMemorystorage. This wraps the counter values within anAtomicI64, which makes it possible to safely update the values with multiple threads.A minor regression was introduced with this change, but will be solved when we get rid of the "normalization" of counters elsewhere and not in
check_and_updateInMemory method.In memory/is_rate_limited/10 namespaces with 50 limits each with 10 conditions and 10 variables
In memory/is_rate_limited/10 namespaces with 10 limits each with 10 conditions and 10 variables
In memory/is_rate_limited/1 namespaces with 1 limits each with 1 conditions and 1 variables