Pass through Pod Affinity Rules

[Boomatang]

Allow Pod Affinity Rules to be defined in the Limitador CR which will be past to the Limitador deployment CR and place in spec.template.spec.affinity.

This change address #76

Validation

• Run make local-setup
• Create the Limitador CR with out Pod Affinity Rules

echo "
   apiVersion: limitador.kuadrant.io/v1alpha1
   kind: Limitador
   metadata:
     name: limitador-sample
   spec:
     replicas: 3
     limits:
       - conditions: ["get_toy == 'yes'"]
         max_value: 2
         namespace: toystore-app
         seconds: 30
         variables: []
   " | kubectl apply -f -

• Expected: deployment has no Affinity Rules

kubectl get deployment limitador-sample -o jsonpath='{.spec.template.spec.affinity}' -n default | jq

• update the Limitador CR to contain Pod Affinity Rules.

echo "
apiVersion: limitador.kuadrant.io/v1alpha1
kind: Limitador
metadata:
  name: limitador-sample
spec:
  replicas: 3
  affinity:
    podAntiAffinity:
      preferredDuringSchedulingIgnoredDuringExecution:
        - weight: 100
          podAffinityTerm:
            labelSelector:
              matchLabels:
                app.kubernetes.io/name: limitador
            topologyKey: kubernetes.io/hostname
        - weight: 99
          podAffinityTerm:
            labelSelector:
              matchLabels:
                app.kubernetes.io/name: limitador
            topologyKey: topology.kubernetes.io/zone
  limits:
    - conditions: ["get_toy == 'yes'"]
      max_value: 2
      namespace: toystore-app
      seconds: 30
      variables: []
   " | kubectl apply -f -

• Expected: deployment contains Affinity Rules

kubectl get deployment limitador-sample -o jsonpath='{.spec.template.spec.affinity}' -n default | jq

• Update the Affinity Rules

echo "
apiVersion: limitador.kuadrant.io/v1alpha1
kind: Limitador
metadata:
  name: limitador-sample
spec:
  replicas: 3
  affinity:
    podAntiAffinity:
      preferredDuringSchedulingIgnoredDuringExecution:
        - weight: 50
          podAffinityTerm:
            labelSelector:
              matchLabels:
                app.kubernetes.io/name: limitador
            topologyKey: kubernetes.io/hostname
        - weight: 50
          podAffinityTerm:
            labelSelector:
              matchLabels:
                app.kubernetes.io/name: limitador
            topologyKey: topology.kubernetes.io/zone
  limits:
    - conditions: ["get_toy == 'yes'"]
      max_value: 2
      namespace: toystore-app
      seconds: 30
      variables: []
   " | kubectl apply -f -

• Expected: deployment Affinity weights to be modified.

kubectl get deployment limitador-sample -o jsonpath='{.spec.template.spec.affinity.podAntiAffinity.preferredDuringSchedulingIgnoredDuringExecution[*].weight}' -n default | jq

• Removing Affinity Rules from Limitador CR removes rules from deployment CR

echo "
   apiVersion: limitador.kuadrant.io/v1alpha1
   kind: Limitador
   metadata:
     name: limitador-sample
   spec:
     replicas: 3
     limits:
       - conditions: ["get_toy == 'yes'"]
         max_value: 2
         namespace: toystore-app
         seconds: 30
         variables: []
   " | kubectl apply -f -

• Expected: deployment has no Affinity Rules

kubectl get deployment limitador-sample -o jsonpath='{.spec.template.spec.affinity}' -n default | jq

[KevFan]

Changes looks good 👍

Just have a minor nit 🧑‍💻

[codecov-commenter]

Codecov Report

Merging #86 (bda6f3d) into main (beaa93e) will decrease coverage by 2.40%.
The diff coverage is 22.22%.

@@            Coverage Diff             @@
##             main      #86      +/-   ##
==========================================
- Coverage   51.83%   49.44%   -2.40%     
==========================================
  Files          13       13              
  Lines         897      906       +9     
==========================================
- Hits          465      448      -17     
- Misses        394      415      +21     
- Partials       38       43       +5     

Flag	Coverage Δ
unit	49.44% <22.22%> (-2.40%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
api/v1alpha1/limitador_types.go	100.00% <ø> (ø)
pkg/reconcilers/deployment.go	21.91% <0.00%> (-2.33%)	⬇️
controllers/limitador_controller.go	42.85% <100.00%> (-3.91%)	⬇️
pkg/limitador/k8s_objects.go	71.72% <100.00%> (+0.14%)	⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[KevFan]

Looks good to me ! 👍