feat: set quay image expiry to prevent overflow of images #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #157 +/- ##
==========================================
- Coverage 85.71% 85.21% -0.51%
==========================================
Files 19 19
Lines 994 994
==========================================
- Hits 852 847 -5
- Misses 93 96 +3
- Partials 49 51 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
KevFan
force-pushed
the
quay-expire-image
branch
from
40ed7cd to
3ec25c1
Compare
Signed-off-by: KevFan <[email protected]>
KevFan
force-pushed
the
quay-expire-image
branch
from
3ec25c1 to
64b0dd2
Compare
eguzki
approved these changes
Sep 18, 2024
Dockerfile
Outdated
| @@ -31,4 +31,9 @@ WORKDIR / | |||
| COPY --from=builder /workspace/manager . | |||
| USER 65532:65532 | |||
|
|
|||
| # Quay image expiry | |||
| ARG QUAY_IMAGE_EXPIRY | |||
| ENV QUAY_IMAGE_EXPIRY=${QUAY_IMAGE_EXPIRY:-never} | |||
There was a problem hiding this comment.
Hmm, I was following the current examples of how this was done. I assumed it was to use the enviroment default value 🤔
Lines 19 to 25 in 1f721de
But this probably can be simpler by doing the following instead if we want to always take it in from the build argument instead
Suggested change
| ENV QUAY_IMAGE_EXPIRY=${QUAY_IMAGE_EXPIRY:-never} | |
| ARG QUAY_IMAGE_EXPIRY=never |
Let me give it a try and push an update
bundle.Dockerfile
Outdated
|
|
||
| # Quay image expiry | ||
| ARG QUAY_IMAGE_EXPIRY | ||
| ENV QUAY_IMAGE_EXPIRY=${QUAY_IMAGE_EXPIRY:-never} |
Signed-off-by: KevFan <[email protected]>
eguzki
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of: Kuadrant/kuadrant-operator#769
Associated with: Kuadrant/kuadrant-operator#843
Currently, all built Quay images never expire and are consuming unnecessary quota on Quay.io. Quay provides a way to set tag expiration from a Dockerfile to prevent this issue for images that don't need to be kept indefinitely, such as development branches and nightly builds. This can help prevent the problem from escalating over time.
Verification
expire_imagestag has an expiry at the following quay repos which was build by the CI for this branch: