Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed version from latest to v0.0.0 #83

Merged
merged 1 commit into from
May 21, 2024
Merged

Conversation

ehearneRedHat
Copy link
Contributor

What:

  • Version in version/version.go has been changed from "latest" to "v0.0.0" to align better with how versions are displayed in kuadrant-operator when compiling non-releases. Change requested by @azgabur .

Verify:

  • run go build in root directory of repo, followed by ./kuadrantctl version which should give the following ouput:
{"level":"info","ts":"2024-05-21T15:50:49+01:00","msg":"kuadrantctl version: v0.0.0"}

@ehearneRedHat ehearneRedHat requested a review from eguzki May 21, 2024 14:51
Copy link
Collaborator

@eguzki eguzki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is indeed good to have.

The next enhancement (not for this PR, though), would be to log the git commit ID or git TAG used to build the binary. Something like:

{"level":"info","ts":"2024-05-21T15:50:49+01:00","msg":"kuadrantctl version: v0.0.0 (e75ae554) "}

or when the GITHUB_SHA env var is available at compile time with version, let's say v0.2.3, then

{"level":"info","ts":"2024-05-21T15:50:49+01:00","msg":"kuadrantctl version: v0.2.3 (e7562342) "}

Limitador component follows this approach.

Just sharing ideas :)

@ehearneRedHat
Copy link
Contributor Author

@eguzki thanks for approving the request and for your suggestion. :) Merging now...

I was speaking about this with @R-Lawton in #82 , and that we were both unsure how we could make this happen. I'm sure with some research possibilities will open up! :)

@ehearneRedHat ehearneRedHat reopened this May 21, 2024
@ehearneRedHat ehearneRedHat merged commit 115d5a2 into main May 21, 2024
9 checks passed
@ehearneRedHat ehearneRedHat deleted the version-latest-0-0-0 branch May 21, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants