Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links to policy docs pages #55

Merged
merged 2 commits into from
May 10, 2024
Merged

Fix links to policy docs pages #55

merged 2 commits into from
May 10, 2024

Conversation

guicassolato
Copy link
Contributor

  • fix rendering of link to AuthPolicy overview
  • point to policy overview pages instead of API references

@openshift-ci openshift-ci bot requested review from eguzki and pmccarthy May 8, 2024 14:00
@guicassolato guicassolato requested a review from maleck13 May 8, 2024 14:00
Copy link

netlify bot commented May 8, 2024

Deploy Preview for relaxed-faloodeh-7fa6f1 ready!

Name Link
🔨 Latest commit 84b4fd4
🔍 Latest deploy log https://app.netlify.com/sites/relaxed-faloodeh-7fa6f1/deploys/663b8579e544d60008f3174d
😎 Deploy Preview https://deploy-preview-55--relaxed-faloodeh-7fa6f1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@guicassolato guicassolato requested a review from jasonmadigan May 8, 2024 14:00
@guicassolato guicassolato self-assigned this May 8, 2024
@@ -46,25 +46,25 @@ tags: index-page # Note: This adds a custom class to layout.njk
<div class="col-xl-3 col-md-6 d-flex align-items-stretch mt-4 mt-md-0" data-aos="zoom-in" data-aos-delay="200">
<div class="icon-box">
<div class="icon"><i class="bx bx-lock"></i></div>
<h4><a href="https://docs.kuadrant.io/latest/kuadrant-operator/doc/reference/tlspolicy/">Secure: TLSPolicy</a></h4>
<h4><a href="https://docs.kuadrant.io/latest/kuadrant-operator/doc/tls/">Secure: TLSPolicy</a></h4>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly the reason why it pointed to the API references before was because the DNSPolicy does not have an Overview page in the docs. IMO though the overview pages are usually richer to explain the concept for one who wants to learn about these policies for the first time.

@maleck13
Copy link
Contributor

maleck13 commented May 9, 2024

/lgtm

@maleck13
Copy link
Contributor

/approve

Copy link

openshift-ci bot commented May 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guicassolato, maleck13

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit a4d6619 into main May 10, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants