-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix links to policy docs pages #55
Conversation
guicassolato
commented
May 8, 2024
- fix rendering of link to AuthPolicy overview
- point to policy overview pages instead of API references
✅ Deploy Preview for relaxed-faloodeh-7fa6f1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@@ -46,25 +46,25 @@ tags: index-page # Note: This adds a custom class to layout.njk | |||
<div class="col-xl-3 col-md-6 d-flex align-items-stretch mt-4 mt-md-0" data-aos="zoom-in" data-aos-delay="200"> | |||
<div class="icon-box"> | |||
<div class="icon"><i class="bx bx-lock"></i></div> | |||
<h4><a href="https://docs.kuadrant.io/latest/kuadrant-operator/doc/reference/tlspolicy/">Secure: TLSPolicy</a></h4> | |||
<h4><a href="https://docs.kuadrant.io/latest/kuadrant-operator/doc/tls/">Secure: TLSPolicy</a></h4> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possibly the reason why it pointed to the API references before was because the DNSPolicy does not have an Overview page in the docs. IMO though the overview pages are usually richer to explain the concept for one who wants to learn about these policies for the first time.
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guicassolato, maleck13 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |