tests: Add dns record deletion tests (orphan records) #942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikenairn
commented
Oct 15, 2024
| //err := k8sClient.Get(ctx, client.ObjectKeyFromObject(gateway), gateway) | ||
| //g.Expect(err).NotTo(HaveOccurred()) | ||
| //g.Expect(gateway.Annotations).ToNot(HaveKey(v1alpha1.DNSPolicyDirectReferenceAnnotationName)) | ||
| //g.Expect(gateway.Annotations).ToNot(HaveKeyWithValue(v1alpha1.DNSPolicyBackReferenceAnnotationName, policiesBackRefValue)) |
There was a problem hiding this comment.
All these back references will be removed as part of the SOTW so we don't really need to worry about fixing these. More just here for me to understand what should be happening currently.
mikenairn
commented
Oct 15, 2024
| ), | ||
| ) | ||
| //ToDo (mnairn) Theres a bug here, this never gets reset when all records are removed due to target removal | ||
| //g.Expect(dnsPolicy.Status.TotalRecords).To(Equal(int32(0))) |
There was a problem hiding this comment.
Issues with the record count will be resolved by the SOTW status reconciler updates.
mikenairn
force-pushed
the
add_dns_record_deletion_tests
branch
2 times, most recently
from
618721d to
aee0a40
Compare
mikenairn
commented
Oct 16, 2024
| { | ||
| Type: ptr.To(gatewayapiv1.IPAddressType), | ||
| //Using the same address can cause a panic in the inmemory provider see https://github.com/Kuadrant/dns-operator/issues/272 | ||
| Value: "172.1.1.1", |
There was a problem hiding this comment.
mikenairn
changed the title
|
@KevFan I haven't reviewed the the TLS tests, but we should probably make sure we have appropriate test coverage there also. |
Adds/Updates tests to better cover dnsrecord deletion scenarios. Signed-off-by: Michael Nairn <[email protected]>
mikenairn
force-pushed
the
add_dns_record_deletion_tests
branch
from
aee0a40 to
9ccf0b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds/Updates tests to better cover dnsrecord deletion scenarios.
Requires: #941