-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: tls policy status to state of the world tasks #885
Merged
+1,223
−998
Merged
Changes from 14 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
b6fe7bd
refactor: tls policy status to state of the world tasks
KevFan 0fe2d41
refactor: improve linking functions
KevFan fdf9bd4
refactor: events from certificate owned by TLSPolicies only
KevFan 270c7c5
test: re-add unit tests for enforced condition
KevFan 33a80fc
feat: status for cert manager not installed in tls policies
KevFan e6a1e4f
fixup: use GroupKind for isObjectOwnedBy function
KevFan a6649f2
fixup: logs
KevFan bd3b3c1
refactor: align with some common conventions
KevFan fddf4ee
fixup: map[string]error for TLSPolicy validation & refine target not …
KevFan 36081c4
refactor: link certs to listeners instead
KevFan 1880122
fixup: subscribe to events for tls status
KevFan fef1ae4
refactor: check for isCertManagerInstalled only from boot
KevFan e974c4b
refactor: struct to store state of dependencies in initial boot
KevFan c83ca3d
refactor: bootOptionsBuilder
KevFan 1093827
fixup: address comments
KevFan 1a391b8
fixup: move getting hostname to outside loop
KevFan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting approach. I wonder how it performs compared to labels.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I went with ownerReference instead since we already set the ownerRef to point to
TLSPolicy
since we want the associatedCertificates
deleted when theTLSPolicy
is deleted.Also we don't currently set a common label across all created
Certificate
'skuadrant-operator/controllers/tlspolicy_certmanager_certificates.go
Lines 161 to 184 in 4793dc4