Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable gateway api alpha APIs #424

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

eguzki
Copy link
Contributor

@eguzki eguzki commented Feb 15, 2024

What

Enable Gateway API alpha APIs for the development environment. It is mandatory for testing current alpha APIs like GRPCRoute API.

Verification steps

Istio operator

make local-setup

When finished, check the discovery controller has PILOT_ENABLE_ALPHA_GATEWAY_API env var set to true

kubectl get deployment istiod -n istio-system -o jsonpath='{.spec.template.spec.containers[?(@.name=="discovery")].env[?(@.name=="PILOT_ENABLE_ALPHA_GATEWAY_API")]}' | yq e -P

Should return

name: PILOT_ENABLE_ALPHA_GATEWAY_API
value: "true"

Sail operator

ISTIO_INSTALL_SAIL=true make local-setup

When finished, check the discovery controller has PILOT_ENABLE_ALPHA_GATEWAY_API env var set to true

kubectl get deployment istiod -n istio-system -o jsonpath='{.spec.template.spec.containers[?(@.name=="discovery")].env[?(@.name=="PILOT_ENABLE_ALPHA_GATEWAY_API")]}' | yq e -P

Should return

name: PILOT_ENABLE_ALPHA_GATEWAY_API
value: "true"

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Merging #424 (53171a3) into main (c831a70) will decrease coverage by 0.90%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #424      +/-   ##
==========================================
- Coverage   66.18%   65.29%   -0.90%     
==========================================
  Files          38       38              
  Lines        3901     3901              
==========================================
- Hits         2582     2547      -35     
- Misses       1131     1158      +27     
- Partials      188      196       +8     
Flag Coverage Δ
integration 69.52% <ø> (-1.73%) ⬇️
unit 60.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) ∅ <ø> (∅)
pkg/common (u) 78.59% <ø> (ø)
pkg/istio (u) 37.11% <ø> (ø)
pkg/log (u) 31.81% <ø> (ø)
pkg/reconcilers (u) 33.44% <ø> (ø)
pkg/rlptools (u) 56.46% <ø> (ø)
controllers (i) 69.52% <ø> (-1.73%) ⬇️

see 5 files with indirect coverage changes

@maleck13
Copy link
Collaborator

Should this be closed @eguzki

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants