more descriptive wasm actionset names

Signed-off-by: Guilherme Cassolato <[email protected]>
Kuadrant · Oct 17, 2024 · 1d18a33 · 1d18a33
1 parent 5f1109a
commit 1d18a33
Show file tree

Hide file tree

Showing 4 changed files with 51 additions and 49 deletions.
diff --git a/api/v1/merge_strategies.go b/api/v1/merge_strategies.go
@@ -17,13 +17,12 @@ limitations under the License.
 package v1
 
 import (
- "crypto/sha256"
- "encoding/hex"
  "sort"
  "strings"
 
  "github.com/samber/lo"
  "k8s.io/apimachinery/pkg/runtime"
+ k8stypes "k8s.io/apimachinery/pkg/types"
 
  "github.com/kuadrant/policy-machinery/controller"
  "github.com/kuadrant/policy-machinery/machinery"
@@ -196,7 +195,7 @@ func PoliciesInPath(path []machinery.Targetable, predicate func(machinery.Policy
 }
 
 func PathID(path []machinery.Targetable) string {
- s := strings.Join(lo.Map(path, machinery.MapTargetableToLocatorFunc), ">")
- hash := sha256.Sum256([]byte(s))
- return hex.EncodeToString(hash[:8])
+ return strings.Join(lo.Map(path, func(t machinery.Targetable, _ int) string {
+  return strings.TrimPrefix(k8stypes.NamespacedName{Namespace: t.GetNamespace(), Name: t.GetName()}.String(), string(k8stypes.Separator))
+ }), "|")
 }
diff --git a/pkg/wasm/utils.go b/pkg/wasm/utils.go
@@ -59,10 +59,10 @@ func BuildActionSetsForPath(pathID string, path []machinery.Targetable, policyRu
  return action, true
  })
 
- return lo.FlatMap(kuadrantgatewayapi.HostnamesFromListenerAndHTTPRoute(listener.Listener, httpRoute.HTTPRoute), func(hostname gatewayapiv1.Hostname, i int) []kuadrantgatewayapi.HTTPRouteMatchConfig {
+ return lo.FlatMap(kuadrantgatewayapi.HostnamesFromListenerAndHTTPRoute(listener.Listener, httpRoute.HTTPRoute), func(hostname gatewayapiv1.Hostname, _ int) []kuadrantgatewayapi.HTTPRouteMatchConfig {
  return lo.Map(httpRouteRule.Matches, func(httpRouteMatch gatewayapiv1.HTTPRouteMatch, j int) kuadrantgatewayapi.HTTPRouteMatchConfig {
  actionSet := ActionSet{
- Name: fmt.Sprintf("%d-%s-%d", i, pathID, j),
+ Name: ActionSetNameForPath(pathID, j+1, string(hostname)),
  Actions: actions,
  }
  routeRuleConditions := RouteRuleConditions{
@@ -84,6 +84,10 @@ func BuildActionSetsForPath(pathID string, path []machinery.Targetable, policyRu
  }), err
 }
 
+func ActionSetNameForPath(pathID string, httpRouteMatchIndex int, hostname string) string {
+ return fmt.Sprintf("%s|%d|%s", pathID, httpRouteMatchIndex+1, string(hostname))
+}
+
 func ConfigFromStruct(structure *_struct.Struct) (*Config, error) {
  if structure == nil {
  return nil, errors.New("cannot desestructure config from nil")

diff --git a/tests/envoygateway/extension_reconciler_test.go b/tests/envoygateway/extension_reconciler_test.go
@@ -102,9 +102,9 @@ var _ = Describe("wasm controller", func() {
  mGateway,
  &machinery.Listener{Listener: &gateway.Spec.Listeners[0], Gateway: mGateway},
  mHTTPRoute,
- &machinery.HTTPRouteRule{HTTPRouteRule: &gwRoute.Spec.Rules[0], HTTPRoute: mHTTPRoute},
+ &machinery.HTTPRouteRule{HTTPRoute: mHTTPRoute, HTTPRouteRule: &gwRoute.Spec.Rules[0], Name: "rule-1"},
  })
- actionSetName = fmt.Sprintf("%d-%s-%d", 0, pathID, 0) // Hostname: 0, HTTPRouteMatch: 0
+ actionSetName = wasm.ActionSetNameForPath(pathID, 1, string(gwRoute.Spec.Hostnames[0]))
 
  gwPolicy = policyFactory(func(policy *kuadrantv1beta3.RateLimitPolicy) {
  policy.Name = "gw"
@@ -270,9 +270,9 @@ var _ = Describe("wasm controller", func() {
  mGateway,
  &machinery.Listener{Listener: &gateway.Spec.Listeners[0], Gateway: mGateway},
  mHTTPRoute,
- &machinery.HTTPRouteRule{HTTPRouteRule: &gwRoute.Spec.Rules[0], HTTPRoute: mHTTPRoute},
+ &machinery.HTTPRouteRule{HTTPRoute: mHTTPRoute, HTTPRouteRule: &gwRoute.Spec.Rules[0], Name: "rule-1"},
  })
- actionSetName = fmt.Sprintf("%d-%s-%d", 0, pathID, 0) // Hostname: 0, HTTPRouteMatch: 0
+ actionSetName = wasm.ActionSetNameForPath(pathID, 1, string(gwRoute.Spec.Hostnames[0]))
 
  routePolicy = policyFactory(func(policy *kuadrantv1beta3.RateLimitPolicy) {
  policy.Name = "route"

diff --git a/tests/istio/extension_reconciler_test.go b/tests/istio/extension_reconciler_test.go
@@ -4,7 +4,6 @@ package istio_test
 
 import (
  "context"
- "fmt"
  "reflect"
  "time"
 
@@ -95,7 +94,7 @@ var _ = Describe("Rate Limiting WasmPlugin controller", func() {
  mGateway,
  &machinery.Listener{Listener: &gateway.Spec.Listeners[0], Gateway: mGateway},
  mHTTPRoute,
- &machinery.HTTPRouteRule{HTTPRouteRule: &httpRoute.Spec.Rules[0], HTTPRoute: mHTTPRoute},
+ &machinery.HTTPRouteRule{HTTPRoute: mHTTPRoute, HTTPRouteRule: &httpRoute.Spec.Rules[0], Name: "rule-1"},
  })
 
  // create ratelimitpolicy
@@ -156,7 +155,7 @@ var _ = Describe("Rate Limiting WasmPlugin controller", func() {
  },
  ActionSets: []wasm.ActionSet{
  {
- Name: fmt.Sprintf("%d-%s-%d", 0, pathID, 0),
+ Name: wasm.ActionSetNameForPath(pathID, 1, "*.example.com"),
  RouteRuleConditions: wasm.RouteRuleConditions{
  Hostnames: []string{"*.example.com"},
  Matches: []wasm.Predicate{
@@ -304,13 +303,13 @@ var _ = Describe("Rate Limiting WasmPlugin controller", func() {
  &machinery.Listener{Listener: &gateway.Spec.Listeners[0], Gateway: mGateway},
  mHTTPRoute,
  }
- httpRouteRuleToys := &machinery.HTTPRouteRule{HTTPRouteRule: &httpRoute.Spec.Rules[0], HTTPRoute: mHTTPRoute}
- httpRouteRuleAssets := &machinery.HTTPRouteRule{HTTPRouteRule: &httpRoute.Spec.Rules[1], HTTPRoute: mHTTPRoute}
+ httpRouteRuleToys := &machinery.HTTPRouteRule{HTTPRoute: mHTTPRoute, HTTPRouteRule: &httpRoute.Spec.Rules[0], Name: "rule-1"}
+ httpRouteRuleAssets := &machinery.HTTPRouteRule{HTTPRoute: mHTTPRoute, HTTPRouteRule: &httpRoute.Spec.Rules[1], Name: "rule-2"}
 
  // GET api.toystore.io/toys*
  actionSet := existingWASMConfig.ActionSets[0]
  pathID := kuadrantv1.PathID(append(basePath, httpRouteRuleToys))
- Expect(actionSet.Name).To(Equal(fmt.Sprintf("%d-%s-%d", 1, pathID, 0))) // Hostname: 1, HTTPRouteMatch: 0
+ Expect(actionSet.Name).To(Equal(wasm.ActionSetNameForPath(pathID, 1, "api.toystore.io")))
  Expect(actionSet.RouteRuleConditions.Hostnames).To(Equal([]string{"api.toystore.io"}))
  Expect(actionSet.RouteRuleConditions.Matches).To(ContainElements(
  wasm.Predicate{
@@ -373,7 +372,7 @@ var _ = Describe("Rate Limiting WasmPlugin controller", func() {
  // POST api.toystore.io/toys*
  actionSet = existingWASMConfig.ActionSets[1]
  pathID = kuadrantv1.PathID(append(basePath, httpRouteRuleToys))
- Expect(actionSet.Name).To(Equal(fmt.Sprintf("%d-%s-%d", 1, pathID, 1))) // Hostname: 1, HTTPRouteMatch: 1
+ Expect(actionSet.Name).To(Equal(wasm.ActionSetNameForPath(pathID, 2, "api.toystore.io")))
  Expect(actionSet.RouteRuleConditions.Hostnames).To(Equal([]string{"api.toystore.io"}))
  Expect(actionSet.RouteRuleConditions.Matches).To(ContainElements(
  wasm.Predicate{
@@ -436,7 +435,7 @@ var _ = Describe("Rate Limiting WasmPlugin controller", func() {
  // api.toystore.io/assets*
  actionSet = existingWASMConfig.ActionSets[2]
  pathID = kuadrantv1.PathID(append(basePath, httpRouteRuleAssets))
- Expect(actionSet.Name).To(Equal(fmt.Sprintf("%d-%s-%d", 1, pathID, 2))) // Hostname: 1, HTTPRouteMatch: 2
+ Expect(actionSet.Name).To(Equal(wasm.ActionSetNameForPath(pathID, 3, "api.toystore.io")))
  Expect(actionSet.RouteRuleConditions.Hostnames).To(Equal([]string{"api.toystore.io"}))
  Expect(actionSet.RouteRuleConditions.Matches).To(ContainElements(
  wasm.Predicate{
@@ -494,7 +493,7 @@ var _ = Describe("Rate Limiting WasmPlugin controller", func() {
  // GET *.toystore.acme.com/toys*
  actionSet = existingWASMConfig.ActionSets[3]
  pathID = kuadrantv1.PathID(append(basePath, httpRouteRuleToys))
- Expect(actionSet.Name).To(Equal(fmt.Sprintf("%d-%s-%d", 0, pathID, 0))) // Hostname: 0, HTTPRouteMatch: 0
+ Expect(actionSet.Name).To(Equal(wasm.ActionSetNameForPath(pathID, 1, "*.toystore.acme.com")))
  Expect(actionSet.RouteRuleConditions.Hostnames).To(Equal([]string{"*.toystore.acme.com"}))
  Expect(actionSet.RouteRuleConditions.Matches).To(ContainElements(
  wasm.Predicate{
@@ -557,7 +556,7 @@ var _ = Describe("Rate Limiting WasmPlugin controller", func() {
  // POST *.toystore.acme.com/toys*
  actionSet = existingWASMConfig.ActionSets[4]
  pathID = kuadrantv1.PathID(append(basePath, httpRouteRuleToys))
- Expect(actionSet.Name).To(Equal(fmt.Sprintf("%d-%s-%d", 0, pathID, 1))) // Hostname: 0, HTTPRouteMatch: 1
+ Expect(actionSet.Name).To(Equal(wasm.ActionSetNameForPath(pathID, 2, "*.toystore.acme.com")))
  Expect(actionSet.RouteRuleConditions.Hostnames).To(Equal([]string{"*.toystore.acme.com"}))
  Expect(actionSet.RouteRuleConditions.Matches).To(ContainElements(
  wasm.Predicate{
@@ -620,7 +619,7 @@ var _ = Describe("Rate Limiting WasmPlugin controller", func() {
  // *.toystore.acme.com/assets*
  actionSet = existingWASMConfig.ActionSets[5]
  pathID = kuadrantv1.PathID(append(basePath, httpRouteRuleAssets))
- Expect(actionSet.Name).To(Equal(fmt.Sprintf("%d-%s-%d", 0, pathID, 2))) // Hostname: 0, HTTPRouteMatch: 2
+ Expect(actionSet.Name).To(Equal(wasm.ActionSetNameForPath(pathID, 3, "*.toystore.acme.com")))
  Expect(actionSet.RouteRuleConditions.Hostnames).To(Equal([]string{"*.toystore.acme.com"}))
  Expect(actionSet.RouteRuleConditions.Matches).To(ContainElements(
  wasm.Predicate{
@@ -690,7 +689,7 @@ var _ = Describe("Rate Limiting WasmPlugin controller", func() {
  mGateway,
  &machinery.Listener{Listener: &gateway.Spec.Listeners[0], Gateway: mGateway},
  mHTTPRoute,
- &machinery.HTTPRouteRule{HTTPRouteRule: &httpRoute.Spec.Rules[0], HTTPRoute: mHTTPRoute},
+ &machinery.HTTPRouteRule{HTTPRoute: mHTTPRoute, HTTPRouteRule: &httpRoute.Spec.Rules[0], Name: "rule-1"},
  })
 
  // create ratelimitpolicy
@@ -746,7 +745,7 @@ var _ = Describe("Rate Limiting WasmPlugin controller", func() {
  },
  ActionSets: []wasm.ActionSet{
  {
- Name: fmt.Sprintf("%d-%s-%d", 0, pathID, 0),
+ Name: wasm.ActionSetNameForPath(pathID, 1, "*.example.com"),
  RouteRuleConditions: wasm.RouteRuleConditions{
  Hostnames: []string{"*.example.com"},
  Matches: []wasm.Predicate{
@@ -938,7 +937,7 @@ var _ = Describe("Rate Limiting WasmPlugin controller", func() {
  mGateway,
  &machinery.Listener{Listener: &gateway.Spec.Listeners[0], Gateway: mGateway},
  mHTTPRoute,
- &machinery.HTTPRouteRule{HTTPRouteRule: &httpRoute.Spec.Rules[0], HTTPRoute: mHTTPRoute},
+ &machinery.HTTPRouteRule{HTTPRoute: mHTTPRoute, HTTPRouteRule: &httpRoute.Spec.Rules[0], Name: "rule-1"},
  })
 
  // Initial state set.
@@ -970,9 +969,9 @@ var _ = Describe("Rate Limiting WasmPlugin controller", func() {
  },
  ActionSets: []wasm.ActionSet{
  {
- Name: fmt.Sprintf("%d-%s-%d", 0, pathID, 0),
+ Name: wasm.ActionSetNameForPath(pathID, 1, "*.example.com"),
  RouteRuleConditions: wasm.RouteRuleConditions{
- Hostnames: []string{"*"},
+ Hostnames: []string{"*.example.com"},
  Matches: []wasm.Predicate{
  {
  Selector: "request.method",
@@ -1118,7 +1117,7 @@ var _ = Describe("Rate Limiting WasmPlugin controller", func() {
  mGateway,
  &machinery.Listener{Listener: &gateway.Spec.Listeners[0], Gateway: mGateway},
  mHTTPRoute,
- &machinery.HTTPRouteRule{HTTPRouteRule: &httpRoute.Spec.Rules[0], HTTPRoute: mHTTPRoute},
+ &machinery.HTTPRouteRule{HTTPRoute: mHTTPRoute, HTTPRouteRule: &httpRoute.Spec.Rules[0], Name: "rule-1"},
  })
 
  // create RLP A -> Route A
@@ -1183,7 +1182,7 @@ var _ = Describe("Rate Limiting WasmPlugin controller", func() {
  },
  ActionSets: []wasm.ActionSet{
  {
- Name: fmt.Sprintf("%d-%s-%d", 0, pathID, 0),
+ Name: wasm.ActionSetNameForPath(pathID, 1, "*.example.com"),
  RouteRuleConditions: wasm.RouteRuleConditions{
  Hostnames: []string{"*.example.com"},
  Matches: []wasm.Predicate{
@@ -1283,7 +1282,7 @@ var _ = Describe("Rate Limiting WasmPlugin controller", func() {
  mGateway,
  &machinery.Listener{Listener: &gateway.Spec.Listeners[0], Gateway: mGateway},
  mHTTPRoute,
- &machinery.HTTPRouteRule{HTTPRouteRule: &httpRoute.Spec.Rules[0], HTTPRoute: mHTTPRoute},
+ &machinery.HTTPRouteRule{HTTPRoute: mHTTPRoute, HTTPRouteRule: &httpRoute.Spec.Rules[0], Name: "rule-1"},
  })
 
  // Check wasm plugin for gateway B has configuration from the route
@@ -1314,7 +1313,7 @@ var _ = Describe("Rate Limiting WasmPlugin controller", func() {
  },
  ActionSets: []wasm.ActionSet{
  {
- Name: fmt.Sprintf("%d-%s-%d", 0, pathID, 0),
+ Name: wasm.ActionSetNameForPath(pathID, 1, "*.example.com"),
  RouteRuleConditions: wasm.RouteRuleConditions{
  Hostnames: []string{"*.example.com"},
  Matches: []wasm.Predicate{
@@ -1485,7 +1484,7 @@ var _ = Describe("Rate Limiting WasmPlugin controller", func() {
  mGateway,
  &machinery.Listener{Listener: &gateway.Spec.Listeners[0], Gateway: mGateway},
  mHTTPRoute,
- &machinery.HTTPRouteRule{HTTPRouteRule: &httpRouteA.Spec.Rules[0], HTTPRoute: mHTTPRoute},
+ &machinery.HTTPRouteRule{HTTPRoute: mHTTPRoute, HTTPRouteRule: &httpRouteA.Spec.Rules[0], Name: "rule-1"},
  })
 
  // Initial state set.
@@ -1517,7 +1516,7 @@ var _ = Describe("Rate Limiting WasmPlugin controller", func() {
  },
  ActionSets: []wasm.ActionSet{
  {
- Name: fmt.Sprintf("%d-%s-%d", 0, pathID, 0),
+ Name: wasm.ActionSetNameForPath(pathID, 1, "*.a.example.com"),
  RouteRuleConditions: wasm.RouteRuleConditions{
  Hostnames: []string{"*.a.example.com"},
  Matches: []wasm.Predicate{
@@ -1580,7 +1579,7 @@ var _ = Describe("Rate Limiting WasmPlugin controller", func() {
  mGateway,
  &machinery.Listener{Listener: &gateway.Spec.Listeners[0], Gateway: mGateway},
  mHTTPRoute,
- &machinery.HTTPRouteRule{HTTPRouteRule: &httpRouteB.Spec.Rules[0], HTTPRoute: mHTTPRoute},
+ &machinery.HTTPRouteRule{HTTPRoute: mHTTPRoute, HTTPRouteRule: &httpRouteB.Spec.Rules[0], Name: "rule-1"},
  })
 
  // Check wasm plugin has configuration from the route B
@@ -1611,7 +1610,7 @@ var _ = Describe("Rate Limiting WasmPlugin controller", func() {
  },
  ActionSets: []wasm.ActionSet{
  {
- Name: fmt.Sprintf("%d-%s-%d", 0, pathID, 0),
+ Name: wasm.ActionSetNameForPath(pathID, 1, "*.b.example.com"),
  RouteRuleConditions: wasm.RouteRuleConditions{
  Hostnames: []string{"*.b.example.com"},
  Matches: []wasm.Predicate{
@@ -1757,7 +1756,7 @@ var _ = Describe("Rate Limiting WasmPlugin controller", func() {
  mGateway,
  &machinery.Listener{Listener: &gateway.Spec.Listeners[0], Gateway: mGateway},
  mHTTPRoute,
- &machinery.HTTPRouteRule{HTTPRouteRule: &httpRouteA.Spec.Rules[0], HTTPRoute: mHTTPRoute},
+ &machinery.HTTPRouteRule{HTTPRoute: mHTTPRoute, HTTPRouteRule: &httpRouteA.Spec.Rules[0], Name: "rule-1"},
  })
 
  // Initial state set.
@@ -1789,9 +1788,9 @@ var _ = Describe("Rate Limiting WasmPlugin controller", func() {
  },
  ActionSets: []wasm.ActionSet{
  {
- Name: fmt.Sprintf("%d-%s-%d", 0, pathID, 0),
+ Name: wasm.ActionSetNameForPath(pathID, 1, "*.a.example.com"),
  RouteRuleConditions: wasm.RouteRuleConditions{
- Hostnames: []string{"*"},
+ Hostnames: []string{"*.a.example.com"},
  Matches: []wasm.Predicate{
  {
  Selector: "request.method",
@@ -1901,7 +1900,7 @@ var _ = Describe("Rate Limiting WasmPlugin controller", func() {
  },
  ActionSets: []wasm.ActionSet{
  {
- Name: fmt.Sprintf("%d-%s-%d", 0, pathID, 0),
+ Name: wasm.ActionSetNameForPath(pathID, 1, "*.a.example.com"),
  RouteRuleConditions: wasm.RouteRuleConditions{
  Hostnames: []string{"*.a.example.com"},
  Matches: []wasm.Predicate{
@@ -2083,7 +2082,7 @@ var _ = Describe("Rate Limiting WasmPlugin controller", func() {
  mGateway,
  &machinery.Listener{Listener: &gateway.Spec.Listeners[0], Gateway: mGateway},
  mHTTPRoute,
- &machinery.HTTPRouteRule{HTTPRouteRule: &httpRouteA.Spec.Rules[0], HTTPRoute: mHTTPRoute},
+ &machinery.HTTPRouteRule{HTTPRoute: mHTTPRoute, HTTPRouteRule: &httpRouteA.Spec.Rules[0], Name: "rule-1"},
  })
 
  // Initial state set.
@@ -2115,7 +2114,7 @@ var _ = Describe("Rate Limiting WasmPlugin controller", func() {
  },
  ActionSets: []wasm.ActionSet{
  {
- Name: fmt.Sprintf("%d-%s-%d", 0, pathID, 0),
+ Name: wasm.ActionSetNameForPath(pathID, 1, "*.a.example.com"),
  RouteRuleConditions: wasm.RouteRuleConditions{
  Hostnames: []string{"*.a.example.com"},
  Matches: []wasm.Predicate{
@@ -2211,7 +2210,7 @@ var _ = Describe("Rate Limiting WasmPlugin controller", func() {
  mGateway,
  &machinery.Listener{Listener: &gateway.Spec.Listeners[0], Gateway: mGateway},
  mHTTPRoute,
- &machinery.HTTPRouteRule{HTTPRouteRule: &httpRouteB.Spec.Rules[0], HTTPRoute: mHTTPRoute},
+ &machinery.HTTPRouteRule{HTTPRoute: mHTTPRoute, HTTPRouteRule: &httpRouteB.Spec.Rules[0], Name: "rule-1"},
  })
 
  expectedPlugin := &wasm.Config{
@@ -2224,7 +2223,7 @@ var _ = Describe("Rate Limiting WasmPlugin controller", func() {
  },
  ActionSets: []wasm.ActionSet{
  {
- Name: fmt.Sprintf("%d-%s-%d", 0, pathID, 0), // Route A affected by RLP 1 -> Route A
+ Name: wasm.ActionSetNameForPath(pathID, 1, "*.a.example.com"),
  RouteRuleConditions: wasm.RouteRuleConditions{
  Hostnames: []string{"*.a.example.com"},
  Matches: []wasm.Predicate{
@@ -2258,9 +2257,9 @@ var _ = Describe("Rate Limiting WasmPlugin controller", func() {
  },
  },
  {
- Name: fmt.Sprintf("%d-%s-%d", 0, pathID_B, 0), // Route B affected by RLP 1 -> Gateway
+ Name: wasm.ActionSetNameForPath(pathID_B, 1, "*.b.example.com"),
  RouteRuleConditions: wasm.RouteRuleConditions{
- Hostnames: []string{"*"},
+ Hostnames: []string{"*.b.example.com"},
  Matches: []wasm.Predicate{
  {
  Selector: "request.method",
@@ -2378,7 +2377,7 @@ var _ = Describe("Rate Limiting WasmPlugin controller", func() {
  mGateway,
  &machinery.Listener{Listener: &gateway.Spec.Listeners[0], Gateway: mGateway},
  mHTTPRoute,
- &machinery.HTTPRouteRule{HTTPRouteRule: &httpRoute.Spec.Rules[0], HTTPRoute: mHTTPRoute},
+ &machinery.HTTPRouteRule{HTTPRoute: mHTTPRoute, HTTPRouteRule: &httpRoute.Spec.Rules[0], Name: "rule-1"},
  })
 
  // Check wasm plugin
@@ -2400,7 +2399,7 @@ var _ = Describe("Rate Limiting WasmPlugin controller", func() {
  },
  ActionSets: []wasm.ActionSet{
  {
- Name: fmt.Sprintf("%d-%s-%d", 0, pathID, 0),
+ Name: wasm.ActionSetNameForPath(pathID, 1, gwHostname),
  RouteRuleConditions: wasm.RouteRuleConditions{
  Hostnames: []string{gwHostname},
  Matches: []wasm.Predicate{
@@ -2466,7 +2465,7 @@ var _ = Describe("Rate Limiting WasmPlugin controller", func() {
  mGateway,
  &machinery.Listener{Listener: &gateway.Spec.Listeners[0], Gateway: mGateway},
  mHTTPRoute,
- &machinery.HTTPRouteRule{HTTPRouteRule: &httpRoute.Spec.Rules[0], HTTPRoute: mHTTPRoute},
+ &machinery.HTTPRouteRule{HTTPRoute: mHTTPRoute, HTTPRouteRule: &httpRoute.Spec.Rules[0], Name: "rule-1"},
  })
 
  return &wasm.Config{
@@ -2479,7 +2478,7 @@ var _ = Describe("Rate Limiting WasmPlugin controller", func() {
  },
  ActionSets: []wasm.ActionSet{
  {
- Name: fmt.Sprintf("%d-%s-%d", 0, pathID, 0),
+ Name: wasm.ActionSetNameForPath(pathID, 1, hostname),
  RouteRuleConditions: wasm.RouteRuleConditions{
  Hostnames: []string{hostname},
  Matches: []wasm.Predicate{