Fix showing of server side validation error response in RLP & DNS cre… #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: david-martin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
david-martin
force-pushed
the
validation
branch
from
a30b1b6
to
f5c85d8
Compare
david-martin
commented
Sep 17, 2024
| @@ -30,7 +30,7 @@ const NamespaceSelect: React.FC<NamespaceSelectProps> = ({ selectedNamespace, on | |||
| onChange(event.currentTarget.value); | |||
| }; | |||
| return ( | |||
| <FormGroup label={t('Namespace')} fieldId="namespace-select"> | |||
| <FormGroup label={t('Namespace')} fieldId="namespace-select" isRequired> | |||
There was a problem hiding this comment.
the namespace select will likely be removed in favour of NamespaceBar. Adding this now for functionality until that change is made
|
👀 |
| console.error('Error parsing YAML:', error); | ||
| } | ||
| handleSubmit(); | ||
| }; |
| <Alert | ||
| variant="info" | ||
| isInline | ||
| title="To set defaults, overrides, and more complex limits, use the YAML view." |
There was a problem hiding this comment.
realise this is from an earlier PR, but an i18n string here would be good
…ate views Signed-off-by: David Martin <[email protected]>
david-martin
force-pushed
the
validation
branch
from
f5c85d8
to
9cfea08
Compare
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ate views
closes #58
The Create button on the DNS & RLP pages is disabled until the name, namespace and targetRef are set.
After that, if there's an error when you click create, it will show an alert box below the form (see screenshot for example)
The changes also include the removal of the custom save function for DNSPolicy via the yaml editor as it isn't required (it was originally added as I thought it was needed to convert matchLabels from an object to an array, and back again at the right time for yaml saving, but that's only the case for the form view). Making this change allows the yaml editor to fall back to the built in save function for that component, which handles creation and showing validation errors.
TODO: