Linting errors, enable lint action on PR, add i18n build CI #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jasonmadigan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jasonmadigan
force-pushed
the
lint-errors
branch
2 times, most recently
from
51c244c
to
d5b416e
Compare
jasonmadigan
changed the title
Signed-off-by: Jason Madigan <[email protected]>
Signed-off-by: Jason Madigan <[email protected]>
jasonmadigan
force-pushed
the
lint-errors
branch
2 times, most recently
from
406995c
to
73bf903
Compare
Signed-off-by: Jason Madigan <[email protected]>
jasonmadigan
force-pushed
the
lint-errors
branch
from
73bf903
to
f49ca5d
Compare
Signed-off-by: Jason Madigan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing some linting errors from
yarn lintWill add some VSCode extensions to auto fix linting errors for convenience.
Also added another CI action for i18n - will run at PR time, check for diffs in i18n runs
Resolves:
#116
#115