Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add APICurio guide #80

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Conversation

david-martin
Copy link
Member

@david-martin david-martin commented Mar 8, 2024

Reached out to APICurio dev @EricWittmann to review

Copy link

netlify bot commented Mar 8, 2024

Deploy Preview for graceful-kangaroo-3c9c10 ready!

Name Link
🔨 Latest commit 38e1aba
🔍 Latest deploy log https://app.netlify.com/sites/graceful-kangaroo-3c9c10/deploys/65f083ce2ebe55000844415c
😎 Deploy Preview https://deploy-preview-80--graceful-kangaroo-3c9c10.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@david-martin david-martin self-assigned this Mar 8, 2024
@david-martin david-martin force-pushed the add-apicurio-kuadrantctl-guide branch from d65341e to 0aba05f Compare March 11, 2024 10:34
@david-martin
Copy link
Member Author

@jasonmadigan you good to lgtm this?
The review from Eric will happen async

@jasonmadigan
Copy link
Member

/lgtm
/approve

needs a rebase I think

@david-martin david-martin force-pushed the add-apicurio-kuadrantctl-guide branch from 0aba05f to 38e1aba Compare March 12, 2024 16:33
@openshift-ci openshift-ci bot removed the lgtm label Mar 12, 2024
@david-martin
Copy link
Member Author

Thanks @jasonmadigan
Rebased now, if you could lgtm again.

@jasonmadigan
Copy link
Member

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Mar 13, 2024
Copy link
Contributor

openshift-ci bot commented Mar 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: david-martin, jasonmadigan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [david-martin,jasonmadigan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit a859962 into main Mar 13, 2024
6 checks passed
@jasonmadigan jasonmadigan deleted the add-apicurio-kuadrantctl-guide branch May 13, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants