Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNS guides nav update #154

Merged
merged 2 commits into from
Dec 11, 2024
Merged

DNS guides nav update #154

merged 2 commits into from
Dec 11, 2024

Conversation

david-martin
Copy link
Member

@david-martin david-martin commented Dec 11, 2024

Moves 2 dns guides out of the reference section of the docs (see before/after screenshots).
1 of the guides was already in the guides section as well (so in 2 places at once), which was confusing if you reached it through the reference section as the side nav would change to the guides area.

I changed the order of the guides to what I thought made more sense as well. The guide for configuring a dns provider is above the guide for configuring the gateway

I also added in a few guides that landed on the v1.0.x branch in a629b43#diff-98d0f806abc9af24e6a7c545d3d77e8f9ad57643e27211d7a7b896113e420ed2R144, but not on main.

before
image

after
image

image

@openshift-ci openshift-ci bot requested review from eguzki and philbrookes December 11, 2024 11:41
Copy link
Contributor

openshift-ci bot commented Dec 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: david-martin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

netlify bot commented Dec 11, 2024

Deploy Preview for graceful-kangaroo-3c9c10 ready!

Name Link
🔨 Latest commit c00cd1a
🔍 Latest deploy log https://app.netlify.com/sites/graceful-kangaroo-3c9c10/deploys/67597b50003d8600080105a3
😎 Deploy Preview https://deploy-preview-154--graceful-kangaroo-3c9c10.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@david-martin david-martin changed the title Move dns guides out of reference DNS guides nav update Dec 11, 2024
@david-martin david-martin requested review from jasonmadigan and removed request for eguzki December 11, 2024 11:48
@jasonmadigan
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 11, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit f6fe023 into main Dec 11, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants