Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNS related doc updates #134

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Conversation

mikenairn
Copy link
Member

@mikenairn mikenairn commented Sep 18, 2024

  • Remove all references to docs from the multicluster-gateway-controller repo and remove it as a source.
  • Remove ManagedZone docs

Requires: Kuadrant/architecture#106 for mkdocs serve -s to work again.

* Remove all references to docs from the multicluster-gateway-controller
  repo and remove it as a source.
* Remove ManagedZone docs

Signed-off-by: Michael Nairn <[email protected]>
Copy link
Contributor

openshift-ci bot commented Sep 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikenairn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

netlify bot commented Sep 18, 2024

Deploy Preview for graceful-kangaroo-3c9c10 ready!

Name Link
🔨 Latest commit 460d5a9
🔍 Latest deploy log https://app.netlify.com/sites/graceful-kangaroo-3c9c10/deploys/66eae70a5e13de0009d3f2d9
😎 Deploy Preview https://deploy-preview-134--graceful-kangaroo-3c9c10.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jasonmadigan
Copy link
Member

reviewed with Kuadrant/architecture#106

@jasonmadigan
Copy link
Member

Will stick an lgtm on when the arch PR merges? ping again

@jasonmadigan
Copy link
Member

jasonmadigan commented Sep 18, 2024

Merged the arch change, triggered a rebuild

Edit: Comment not close jason you donut

@jasonmadigan
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 18, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit bc66167 into main Sep 18, 2024
12 checks passed
@mikenairn mikenairn deleted the dns_related_doc_updates branch September 18, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants